Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f311d050da
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| uri: `${cigServiceUrl}${BASE_PATH}/delete`, | ||
| }); | ||
| return getClientCredentials({clientId, clientSecret, idbrokerUrl}).then((authorization) => |
There was a problem hiding this comment.
Key cached client tokens by credentials
When one process removes users owned by more than one client, this call can authorize a deletion with the wrong account: getClientCredentials() returns the single module-global clientToken before considering the supplied clientId, clientSecret, or idbrokerUrl. After a user owned by client A has been created or removed, a later removeTestUser({...clientBCredentials}) still sends A's token, so the newly required creator-account authorization rejects deletion of B's user. Cache tokens per credential tuple (or avoid the global cache for this path).
Useful? React with 👍 / 👎.
robstax
left a comment
There was a problem hiding this comment.
codex comment seems technically possible, but i don't practically a concern?
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
CIG service created test users must be deleted with an authorized account. Test user deletion in integration tests has been failing for a while.
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.