fix(linux): prefer WebGL renderer for Lightning exports with WebGPU f… - #970
Hashim-Bhagad wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughChangesLightning backend fallback
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant ModernVideoExporter
participant backendPolicy
participant ModernFrameRenderer
participant WebCodecs
ModernVideoExporter->>backendPolicy: Resolve platform backend preference
ModernVideoExporter->>ModernFrameRenderer: Construct renderer
ModernFrameRenderer->>backendPolicy: Resolve backend order
ModernFrameRenderer->>WebCodecs: Render with selected backend
WebCodecs-->>ModernVideoExporter: Return _resourceType failure
ModernVideoExporter->>ModernFrameRenderer: Retry with WebGL
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No concrete merge-blocking defect remains in the platform-aware WebGL fallback. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Lightning exports on Linux default to the WebGL renderer instead of WebGPU, and retry once with WebGL if a Pixi WebGPU
_resourceTyperender failure occurs. Explicit backend overrides are still respected.Motivation
Fixes #644: Lightning (Beta) export fails immediately on Linux with
Cannot read properties of undefined (reading '_resourceType')while Legacy works. WebGPU initializes successfully on Linux Mesa/Intel but produces invalid GPU resources on first frame render. Legacy and the preview already render WebGL-first, which is why they were unaffected.Type of Change
Related Issue(s)
Fixes #644
Testing Guide
npx vitest --run— 133 files / 1190 tests pass, including new regression tests for Linux renderer preference/ordering and the_resourceType→ WebGL retrynpx tsc --noEmit— cleannpx vite build— succeedsChecklist
Summary by CodeRabbit