Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions electron/electron-env.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,10 @@ interface Window {
startDelayMsByPath?: Record<string, number>;
error?: string;
}>;
setRecordingState: (recording: boolean) => Promise<void>;
setRecordingState: (
recording: boolean,
options?: { mediaTimelineStartedAtEpochMs?: number },
) => Promise<{ cursorOverlayAvailable: boolean }>;
getCursorTelemetry: (videoPath?: string) => Promise<{
success: boolean;
samples: CursorTelemetryPoint[];
Expand Down Expand Up @@ -839,7 +842,6 @@ interface Window {
onMenuSaveProject: (callback: () => void) => () => void;
onMenuSaveProjectAs: (callback: () => void) => () => void;
getPlatform: () => Promise<string>;
getLinuxWindowSystem: () => Promise<"wayland" | "x11" | null>;
revealInFolder: (
filePath: string,
) => Promise<{ success: boolean; error?: string; message?: string }>;
Expand Down Expand Up @@ -904,6 +906,15 @@ interface Window {
cancelCountdown: () => Promise<{ success: boolean }>;
getActiveCountdown: () => Promise<{ success: boolean; seconds: number | null }>;
onCountdownTick: (callback: (seconds: number) => void) => () => void;
/** Linux portal: wait for the user to accept the screen permission dialog */
beginScreenPermissionWait: () => Promise<{
success: boolean;
cancelled?: boolean;
error?: string;
}>;
endScreenPermissionWait: (granted: boolean) => Promise<{ success: boolean }>;
getAwaitingScreenPermission: () => Promise<{ success: boolean; awaiting: boolean }>;
onAwaitingScreenPermission: (callback: (awaiting: boolean) => void) => () => void;
};
}

Expand Down
36 changes: 3 additions & 33 deletions electron/gpuSwitches.ts
Original file line number Diff line number Diff line change
@@ -1,43 +1,13 @@
import { resolveLinuxWindowSystem } from "./linuxWindowSystem";

export interface GpuSwitches {
useAngle?: string;
useGl?: string;
disableFeatures?: string[];
}

function normalizeLinuxWindowSystem(value: string | undefined): "wayland" | "x11" | null {
const normalized = value?.trim().toLowerCase();
if (normalized === "wayland" || normalized === "x11") {
return normalized;
}

return null;
}

function getForcedLinuxWindowSystem(env: NodeJS.ProcessEnv): "wayland" | "x11" | null {
return (
normalizeLinuxWindowSystem(env.OZONE_PLATFORM) ??
normalizeLinuxWindowSystem(env.ELECTRON_OZONE_PLATFORM_HINT)
);
}

export function shouldForceLinuxEgl(env: NodeJS.ProcessEnv): boolean {
const forcedWindowSystem = getForcedLinuxWindowSystem(env);
if (forcedWindowSystem === "wayland") {
return false;
}
if (forcedWindowSystem === "x11") {
return true;
}

const sessionType = env.XDG_SESSION_TYPE?.toLowerCase();
if (sessionType === "wayland") {
return false;
}
if (sessionType === "x11") {
return true;
}

return !env.WAYLAND_DISPLAY;
return resolveLinuxWindowSystem("linux", env) !== "wayland";
}

export function getGpuSwitches(
Expand Down
192 changes: 192 additions & 0 deletions electron/ipc/cursor/hyprland.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,192 @@
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";

vi.mock("electron", () => ({
app: {
getPath: vi.fn(() => "/tmp"),
},
}));

import { activeCursorSamples, linuxCursorScreenPoint, setActiveCursorSamples } from "../state";
import {
getHyprlandRequestSocketPath,
isHyprlandCursorProviderActive,
parseHyprlandCursorPosition,
resolveHyprlandCursorCaptureEpochMs,
startHyprlandCursorProvider,
stopHyprlandCursorProvider,
} from "./hyprland";

const waylandEnv = {
XDG_RUNTIME_DIR: "/run/user/1000",
XDG_SESSION_TYPE: "wayland",
WAYLAND_DISPLAY: "wayland-1",
HYPRLAND_INSTANCE_SIGNATURE: "abc123_456",
};

describe("Hyprland cursor provider", () => {
beforeEach(() => {
stopHyprlandCursorProvider();
vi.useRealTimers();
});

afterEach(() => {
stopHyprlandCursorProvider();
vi.useRealTimers();
});

it("resolves the Hyprland request socket on native Wayland", async () => {
expect(getHyprlandRequestSocketPath(waylandEnv, "linux")).toBe(
"/run/user/1000/hypr/abc123_456/.socket.sock",
);
});

it("does not start until the cursor socket returns an initial point", async () => {
await expect(
startHyprlandCursorProvider({
env: waylandEnv,
platform: "linux",
query: vi.fn().mockResolvedValue(null),
}),
).resolves.toBe(false);
expect(isHyprlandCursorProviderActive()).toBe(false);
});

it("does not activate for X11 or unsafe instance signatures", () => {
expect(
getHyprlandRequestSocketPath({ ...waylandEnv, OZONE_PLATFORM: "x11" }, "linux"),
).toBeNull();
expect(
getHyprlandRequestSocketPath(
{ ...waylandEnv, OZONE_PLATFORM: "auto", ELECTRON_OZONE_PLATFORM_HINT: "x11" },
"linux",
),
).toBeNull();
expect(
getHyprlandRequestSocketPath(
{ ...waylandEnv, HYPRLAND_INSTANCE_SIGNATURE: "../../other" },
"linux",
),
).toBeNull();
expect(getHyprlandRequestSocketPath(waylandEnv, "darwin")).toBeNull();
});

it("parses finite logical cursor coordinates", () => {
expect(parseHyprlandCursorPosition('{"x":-120.5,"y":480}')).toEqual({
x: -120.5,
y: 480,
});
expect(parseHyprlandCursorPosition('{"x":"12","y":4}')).toBeNull();
expect(parseHyprlandCursorPosition("not json")).toBeNull();
});

it("keeps cursor capture aligned with the media timeline (no legacy offset)", () => {
// The 300 ms correction compensated for telemetry starting before the
// capture; with the portal permission gate, both start together.
expect(resolveHyprlandCursorCaptureEpochMs(10_000)).toBe(10_000);
});

it("polls serially and stops without publishing a late response", async () => {
vi.useFakeTimers();
let resolveQuery!: (point: { x: number; y: number }) => void;
const query = vi.fn(
() =>
new Promise<{ x: number; y: number }>((resolve) => {
resolveQuery = resolve;
}),
);
const onPoint = vi.fn();

const started = startHyprlandCursorProvider({
env: waylandEnv,
platform: "linux",
query,
onPoint,
pollIntervalMs: 10,
});
expect(query).toHaveBeenCalledOnce();
expect(isHyprlandCursorProviderActive()).toBe(false);

stopHyprlandCursorProvider();
expect(isHyprlandCursorProviderActive()).toBe(false);
resolveQuery({ x: 10, y: 20 });
await vi.runAllTimersAsync();

await expect(started).resolves.toBe(false);
expect(onPoint).not.toHaveBeenCalled();
expect(query).toHaveBeenCalledOnce();
});

it("publishes the initial compositor response before reporting success", async () => {
const onPoint = vi.fn();

await expect(
startHyprlandCursorProvider({
env: waylandEnv,
platform: "linux",
query: vi.fn().mockResolvedValue({ x: 12, y: 34 }),
onPoint,
pollIntervalMs: 60_000,
}),
).resolves.toBe(true);

expect(onPoint).toHaveBeenCalledWith({ x: 12, y: 34 });
expect(isHyprlandCursorProviderActive()).toBe(true);
});

it("only refreshes provider state and clears it when polling fails", async () => {
vi.useFakeTimers();
setActiveCursorSamples([]);
const query = vi.fn().mockResolvedValueOnce({ x: 12, y: 34 }).mockResolvedValueOnce(null);

await startHyprlandCursorProvider({
env: waylandEnv,
platform: "linux",
query,
pollIntervalMs: 10,
});

expect(linuxCursorScreenPoint).toMatchObject({
x: 12,
y: 34,
coordinateSpace: "logical",
source: "hyprland",
});
expect(activeCursorSamples).toEqual([]);

await vi.advanceTimersByTimeAsync(10);
expect(linuxCursorScreenPoint).toBeNull();
expect(isHyprlandCursorProviderActive()).toBe(false);
});

it("keeps a successful provider healthy while the next query is pending", async () => {
vi.useFakeTimers();
vi.setSystemTime(1_000);
let resolvePendingQuery!: (point: { x: number; y: number } | null) => void;
const query = vi
.fn()
.mockResolvedValueOnce({ x: 12, y: 34 })
.mockImplementationOnce(
() =>
new Promise<{ x: number; y: number } | null>((resolve) => {
resolvePendingQuery = resolve;
}),
);

await startHyprlandCursorProvider({
env: waylandEnv,
platform: "linux",
query,
pollIntervalMs: 33,
});
expect(isHyprlandCursorProviderActive()).toBe(true);

await vi.advanceTimersByTimeAsync(33);
expect(query).toHaveBeenCalledTimes(2);
await vi.advanceTimersByTimeAsync(167);
expect(isHyprlandCursorProviderActive()).toBe(true);

resolvePendingQuery(null);
await vi.advanceTimersByTimeAsync(0);
expect(isHyprlandCursorProviderActive()).toBe(false);
});
});
Loading