Repository navigation
Remove unused dependencies: react-icons and emoji-picker-react - #1123
Open
ahmed-husssain wants to merge 1867 commits into
Open
ahmed-husssain wants to merge 1867 commits into
ahmed-husssain wants to merge 1867 commits into
Conversation
…-recording-resume-fix Improve app presence and preview/export fidelity
…r-visual-polish Polish editor preview and motion blur
…ws-hud-passthrough fix windows passthrough
…ase-cleanup Clean up codebase formatting, dependencies, extension system removal
Use practical bitrate targets across export backends and add dithering when converting full-range canvas frames to BT.709 video range.
Record captured frames with BT.709 conversion and explicit limited-range metadata. Share the Windows conversion code between capture engines and apply matching colour metadata on macOS and FFmpeg fallbacks.
…ncement-popups Add announcements and polish recording motion
…imental-update-modal Fix experimental update channel and toast
…ware-decode-retry Recover Lightning decoding and add voluntary export error reports
…rt-preferences-separation Keep export preferences separate from project edits
…arding-email-sign-in Add first-launch onboarding and email sign-in
…ed-sharing-ownership Add account-scoped hosted sharing with bounded uploads
…-loading-autosave Improve Home loading, thumbnails, and automatic project saves
…d-publish-ui Add Link and Local publishing and a shared cloud library
…back-access-hardening Tighten feedback table access and add rollback verification
Drag any corner of the floating webcam preview to resize it (120-480px per side, kept inside the HUD viewport). The chosen size is saved and restored the next time the HUD opens. Fixes webadderallorg#1103 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ting-preview-resizability Make the floating webcam preview resizable
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The removed packages are not used by tracked application or tooling files, and the lockfile reflects their removal. The change is ready to merge after normal checks. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the main change: removing the unused react-icons and emoji-picker-react dependencies. |
| Description check | |
The description explains the issue, proposed fix, motivation, and testing status. It does not use the template headings and omits explicit type, related issues, screenshots, and checklist items, but i… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Author
|
Hi @webadderall, all checks and CodeRabbit reviews passed with zero warnings. Ready for review and merge whenever you have a moment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue?
Two packages in
package.jsonare installed but never used anywhere in the project:react-icons: We already use@solar-iconsand@phosphor-iconsfor all icons.react-iconshas 0 imports insrc/.emoji-picker-react: Not imported or used anywhere in the app.Suggested Fix
react-iconsandemoji-picker-reactfrompackage.json.react-iconsexclude list invite.config.ts.package-lock.json.Why do this?
npm installand build times.node_modulessize.I've already tested this locally and all tests pass. I'm happy to open a quick PR if this looks good to you!
Summary by CodeRabbit