Skip to content

test: fix get_element_tag_name test to expect lowercase tagname#60167

Open
juliandescottes wants to merge 1 commit into
web-platform-tests:masterfrom
juliandescottes:fix1956-tagname-lowercase-wpt
Open

test: fix get_element_tag_name test to expect lowercase tagname#60167
juliandescottes wants to merge 1 commit into
web-platform-tests:masterfrom
juliandescottes:fix1956-tagname-lowercase-wpt

Conversation

@juliandescottes

Copy link
Copy Markdown
Contributor

@juliandescottes

Copy link
Copy Markdown
Contributor Author

Thanks for the quick review!

@whimboo

whimboo commented May 26, 2026

Copy link
Copy Markdown
Contributor

I wonder if we should add another test which returns the tag name of a namespaced element like svg:g or similar.

@gsnedders

Copy link
Copy Markdown
Member

I wonder if we should add another test which returns the tag name of a namespaced element like svg:g or similar.

And elements whose local name is not entirely ASCII lowercase (e.g., svg:linearGradient), or whose namespace prefix is not entirely ASCII lowercase (e.g., xmlns:SvG="http://www.w3.org/2000/svg").

Plus obvious edge-cases from the definition of tagName, for example HTML elements where the node document is not an HTML document. (Really we probably want to test all these cases in both HTML documents and non-HTML documents!)

@gsnedders

Copy link
Copy Markdown
Member

https://github.com/web-platform-tests/wpt/blob/master/dom/nodes/Element-tagName.html may also be useful as inspiration here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants