feat(builder): enable Rspack native watcher by default - #8813
Open
stormslowly wants to merge 1 commit into
Open
Conversation
Enable `experiments.nativeWatcher` so watch mode uses Rspack's Rust watcher instead of Watchpack. Applied via `modifyRspackConfig` with `??=` so both `tools.rspack` and `tools.bundlerChain` can still opt out.
🦋 Changeset detectedLatest commit: 47c847c The changes in this PR will be included in the next version bump. This PR includes changesets to release 119 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Modern.js watch mode currently falls back to Rspack's default Watchpack-based watcher. Watchpack degrades badly when a large number of files change at once (webpack/watchpack#223), which shows up in dev on big apps. Rspack's Rust native watcher does incremental change detection and avoids that class of problem.
Before / after (
experimentsin the generated Rspack config):"experiments": { + "nativeWatcher": true, "sourceImport": true, }What
Registers a small Rsbuild plugin in
@modern-js/builderthat setsexperiments.nativeWatcherthroughmodifyRspackConfig.Two escape hatches, both covered by tests:
Notes
NativeWatchFileSystemrejects a function forwatchOptions.ignored(string / array / RegExp only). The only place this repo sets it (adapterBasic.ts) uses a string array, so nothing here breaks — but it is a behavior difference worth calling out for anyone passing a function throughtools.rspack.Verification
@modern-js/builderunit tests: 46 passed, 0 failed.nativeWatcher=undefined -> NodeWatchFileSystem,nativeWatcher=true -> NativeWatchFileSystem.modern devontests/integration/basic-app, editedsrc/App.tsx, confirmed the incremental rebuild fires.