fix: correct 'Middlware' typo in BFF middleware identifiers - #8791
Open
deepcoldy wants to merge 1 commit into
Open
fix: correct 'Middlware' typo in BFF middleware identifiers#8791deepcoldy wants to merge 1 commit into
deepcoldy wants to merge 1 commit into
Conversation
Rename the exported `PublicMiddlwareOptions` type in @modern-js/server-core to `PublicMiddlewareOptions`, and the internal `routeMiddlwares` variable in @modern-js/plugin-bff to `routeMiddlewares`. Pure rename, no behavior change.
🦋 Changeset detectedLatest commit: 7a65f29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 118 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Rsdoctor Bundle Diff Analysis📊 Quick Summary
Generated by Rsdoctor GitHub Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a "Middlware" typo in two BFF middleware identifiers. Pure rename, no behavior change:
@modern-js/server-core: rename the exported typePublicMiddlwareOptions→PublicMiddlewareOptions(packages/server/core/src/adapters/node/plugins/static.ts). This type is re-exported from the package's./nodeentry, so a changeset is included.@modern-js/plugin-bff: rename the internal local variablerouteMiddlwares→routeMiddlewares(packages/cli/plugin-bff/src/utils/createHonoRoutes.ts).Verification
pnpm --filter @modern-js/server-core build✅pnpm --filter @modern-js/plugin-bff build✅pnpm --filter @modern-js/server-core test✅pnpm --filter @modern-js/plugin-bff test✅biome checkon both changed files ✅Related Links
Spotted while investigating #8782.
Checklist
pnpm run change.