Fix overlapping text in wide terminals - #2
Open
sj26 wants to merge 1 commit into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a0469c-cefd-7686-8c3a-cb62a8cce4aa Co-authored-by: Samuel Cochran <sj26@sj26.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When interactive playback advances between paragraphs, the terminal renderer moves up from the status line but keeps its horizontal cursor position. It then clears and rewrites the completed paragraph from that offset, leaving the old text on the left and producing duplicated, overlapping output—especially visibly in wide terminals.
What
Return the cursor to column zero before clearing and committing the completed paragraph. Add a focused regression test for the emitted cursor sequence so future changes cannot reintroduce the offset rendering.
Validation:
.venv/bin/python -m unittest discover -s tests -v— 1 test passed.venv/bin/python -m py_compile aloud.py tests/test_terminal_rendering.py— passedgit diff --check origin/main...HEAD— passed