Skip to content

fix(weave): ignore unfinished calls in latency stats - #7719

Open
gtarpenning wants to merge 1 commit into
masterfrom
griffin/fix-negative-call-stats-latency
Open

fix(weave): ignore unfinished calls in latency stats#7719
gtarpenning wants to merge 1 commit into
masterfrom
griffin/fix-negative-call-stats-latency

Conversation

@gtarpenning

Copy link
Copy Markdown
Member

Summary

  • Ignore latency values when ended_at precedes started_at, covering the epoch sentinel used by unfinished calls.
  • Keep unfinished calls in request and error counts, and preserve valid zero-duration calls.
  • Extend ClickHouse regression coverage for completed, unfinished, and zero-duration calls.

Testing

  • 13 passed in the call-metrics query-builder suite.
  • 12 passed across call-stats integration coverage, including the calls-complete regression case.
  • Pre-push Ty, Pyright, mypy, import-linter, Ruff, and Fixit checks passed.

@gtarpenning
gtarpenning marked this pull request as ready for review August 11, 2026 16:42
@gtarpenning
gtarpenning requested a review from a team as a code owner August 11, 2026 16:42
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants