[codex] Add advisor watchdog for stale task-output waits - #3461
Draft
morganmcg1 wants to merge 1 commit into
Draft
[codex] Add advisor watchdog for stale task-output waits#3461morganmcg1 wants to merge 1 commit into
morganmcg1 wants to merge 1 commit into
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
morganmcg1
force-pushed
the
codex/generic-advisor-watchdog
branch
from
May 24, 2026 08:34
50cec12 to
221f91e
Compare
morganmcg1
force-pushed
the
codex/generic-advisor-watchdog
branch
from
May 25, 2026 12:21
221f91e to
1a05ace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a narrowly scoped advisor watchdog path for stale Claude task-output waiters. This covers both observed DL24 stall variants without matching one literal sentinel string and without adding new launch/config surface.
What changed
/tmp/claude-.../tasks/*.outputthat useuntil,grep -q,sleep, anddone.ERROR|===waiter, the later custom grep waiter, and the safety case where a live Python worker is still running.Why
The DL24 advisor pod was kube-healthy but the advisor loop wedged behind stale Bash waiters on Claude task output files. The first stall waited for the
ERROR|===sentinel; the later recurrence waited for a custom grep sentinel (no val yet|... state|... error). In both cases the task output file was stale and no real worker process remained below the waiter.The fix keeps the boundary narrow: it still requires a Claude task-output path, a polling grep/sleep waiter, stale file mtime, and no real work below the waiter. It just stops depending on one exact sentinel string.
Validation
bash -n k8s/advisor-claude-watchdog.sh tests/test_advisor_claude_watchdog.shbash tests/test_advisor_claude_watchdog.sh