Skip to content

fix(deps): Mount writable directories for Clickhouse Keeper and SeaweedFS - #324

Merged
casey-coreweave merged 2 commits into
mainfrom
cabernathy/seaweed-clichouse-runtime-writes
Aug 12, 2026
Merged

fix(deps): Mount writable directories for Clickhouse Keeper and SeaweedFS#324
casey-coreweave merged 2 commits into
mainfrom
cabernathy/seaweed-clichouse-runtime-writes

Conversation

@casey-coreweave

@casey-coreweave casey-coreweave commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Mounts empty dir volumes for managed Clickhouse Keeper and SeaweedFS to allow disabling of rootFS writes

Summary by CodeRabbit

  • Bug Fixes
    • Improved Keeper log handling by providing dedicated writable storage for logs.
    • Added writable temporary storage to the SeaweedFS S3 gateway, improving runtime reliability for temporary files.

@casey-coreweave
casey-coreweave requested a review from a team as a code owner August 11, 2026 00:09
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b6adb03-9080-4fac-ab9d-cda507f06ad3

📥 Commits

Reviewing files that changed from the base of the PR and between 97e2635 and 0223045.

📒 Files selected for processing (5)
  • internal/controller/infra/managed/clickhouse/altinity/keeper/spec.go
  • internal/controller/infra/managed/clickhouse/altinity/keeper/spec_test.go
  • internal/controller/infra/managed/clickhouse/altinity/keeper/values.go
  • internal/controller/infra/managed/objectstore/seaweedfs/spec.go
  • internal/controller/infra/managed/objectstore/seaweedfs/spec_test.go

📝 Walkthrough

Walkthrough

Keeper now mounts an EmptyDir volume for logs. The SeaweedFS S3 gateway now mounts writable temporary storage at /tmp. Tests verify both pod configurations.

Changes

Runtime storage configuration

Layer / File(s) Summary
Keeper log volume
internal/controller/infra/managed/clickhouse/altinity/keeper/values.go, internal/controller/infra/managed/clickhouse/altinity/keeper/spec.go, internal/controller/infra/managed/clickhouse/altinity/keeper/spec_test.go
Keeper defines log volume constants, adds an EmptyDir volume and mount, and verifies the generated pod specification.
SeaweedFS temporary volume
internal/controller/infra/managed/objectstore/seaweedfs/spec.go, internal/controller/infra/managed/objectstore/seaweedfs/spec_test.go
SeaweedFS S3 receives the writable temporary volume and /tmp mount. Tests verify the configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: amwarrier

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the writable directory mounts added for ClickHouse Keeper and SeaweedFS.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cabernathy/seaweed-clichouse-runtime-writes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@casey-coreweave
casey-coreweave merged commit 42e4c49 into main Aug 12, 2026
10 of 11 checks passed
@casey-coreweave
casey-coreweave deleted the cabernathy/seaweed-clichouse-runtime-writes branch August 12, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants