Skip to content

feat(controller): Reconcile ActionRun jobs - #305

Open
amwarrier wants to merge 6 commits into
codex/triage-run-apifrom
codex/triage-run-controller
Open

feat(controller): Reconcile ActionRun jobs#305
amwarrier wants to merge 6 commits into
codex/triage-run-apifrom
codex/triage-run-controller

Conversation

@amwarrier

@amwarrier amwarrier commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Add the ActionRun reconciler and the triage action catalog to Application.

An Application declares a shared triage runner (command, base args, env, resources, timeout) plus action objects containing name, description, and optional action-specific args. One ActionRun selects one catalog entry and creates one owned, one-shot Job.

The Job inherits the Application workload's service account and runtime context, uses the smaller action resource envelope, and receives the immutable selection through:

WANDB_ACTION_TYPE=triage
WANDB_ACTION_NAME=<selected-name>

The controller remains application-agnostic. It reads structured JSONL stdout, records flat phase/results/summary state on the ActionRun, and uses standard Kubernetes status conditions. maintenance is accepted by the API but fails with UnsupportedActionType until its execution and safety semantics are implemented.

Validation

  • go test ./internal/controller ./internal/controller/reconciler ./cmd/manager
  • go vet ./internal/controller ./internal/controller/reconciler ./cmd/manager
  • generated RBAC, CRDs, deep-copy code, and embedded CRDs are synchronized

Stack

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f1bff9d1-ca59-4076-b510-e9417b1dc068

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/triage-run-controller

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@amwarrier
amwarrier marked this pull request as ready for review July 31, 2026 19:40
@amwarrier
amwarrier requested a review from a team as a code owner July 31, 2026 19:40
@amwarrier
amwarrier force-pushed the codex/triage-run-api branch from a79a269 to a093d55 Compare August 3, 2026 16:37
@amwarrier
amwarrier force-pushed the codex/triage-run-controller branch 2 times, most recently from 0bf21f7 to 1e100d3 Compare August 3, 2026 16:38
@amwarrier amwarrier changed the title feat(controller): reconcile TriageRun jobs feat(controller): Reconcile TriageRun jobs Aug 3, 2026
@amwarrier
amwarrier force-pushed the codex/triage-run-api branch from a093d55 to 373408f Compare August 3, 2026 16:40
@amwarrier
amwarrier force-pushed the codex/triage-run-controller branch 3 times, most recently from 9d87b4e to efc3799 Compare August 4, 2026 15:48
@amwarrier
amwarrier force-pushed the codex/triage-run-controller branch 3 times, most recently from 3bf759a to 418f4fd Compare August 6, 2026 16:33
@amwarrier
amwarrier force-pushed the codex/triage-run-controller branch from 7baf1a4 to 5364d4a Compare August 13, 2026 21:03
@amwarrier amwarrier changed the title feat(controller): Reconcile TriageRun jobs feat(controller): reconcile ActionRun jobs Aug 13, 2026
@amwarrier amwarrier changed the title feat(controller): reconcile ActionRun jobs feat(controller): Reconcile ActionRun jobs Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant