Conversation
…terns that contain triple patterns
Member
|
Oh indeed, I think we're also missing spec tests for these cases. Created w3c/rdf-tests#361 to add them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When discussing Ruben's recent PR #388, I realized that algebraic query expression of the form Path(x, ppe, y) need to be extended such that both x and y may be a triple pattern. But then I also realized that we actually need to extend the whole evaluation of property path pattern to cover property path patterns that contain triple patterns. This PR enters that rabbit hole.
The PR is still incomplete: the evaluation of ZeroOrMorePath still needs to be extended, and so does the evaluation of evaluation of OneOrMorePath and the evaluation of NegatedPropertySet. But maybe some of you want to take a look already?
When working on this PR, I also discovered issues #393, #394, and #395. This PR adds notes for these issues into the spec.
Preview | Diff