Repository navigation
chore(go): bump go directive to 1.27 - #523
Merged
Merged
Conversation
revive v1.16.0 requires go >= 1.26.0, so `go install github.com/mgechev/revive@latest` in `make lint` fails under the go 1.25.0 toolchain that setup-go picks from go.mod (GOTOOLCHAIN=local).
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The valid Go version bump resolves the documented CI incompatibility without unrelated changes.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the module’s minimum Go version so CI can install the latest revive release successfully.
Changes:
- Raises the Go directive from 1.25.0 to 1.27.0.
| File | Description |
|---|---|
go.mod |
Updates the required Go toolchain version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
With `go 1.27.0`, actions/setup-go (go-version-file: go.mod) installs exactly 1.27.0 even when a newer patch release exists. `go 1.27` lets CI and release builds pick up the latest 1.27.x.
shino
changed the title
MaineK00n
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
Bump the
godirective in go.mod from 1.25.0 to 1.27.The Build job of the Test workflow currently fails on every pull request (e.g. #520), because the lint step cannot install revive.
make lintrunsgo install github.com/mgechev/revive@latest, and revive v1.16.0 requires go >= 1.26.0. The workflows set up Go withgo-version-file: go.mod, so CI runs go 1.25.0 withGOTOOLCHAIN=localand the install is rejected:Raising the directive makes setup-go install a toolchain that can build the latest revive. It is written as
go 1.27rather thango 1.27.0so that setup-go resolves it to the latest 1.27.x patch release instead of pinning exactly 1.27.0. Only go.mod changes;go mod tidyproduced no further diff.Note: building this module from source now requires Go 1.27 or later. Release binaries and the Docker image (
golang:alpinebuilder) are unaffected.Type of change
How Has This Been Tested?
Locally with go1.27.0:
make test(revive@latest install + lint, vet, fmtcheck, unit tests) passesgolangci-lint runwith golangci-lint v2.14.0 built with go1.27.0: 0 issuesChecklist:
You don't have to satisfy all of the following.
make fmtmake testIs this ready for review?: YES