Skip to content

Use config array instead of object for Overdrive connectors - #5658

Merged
demiankatz merged 3 commits into
vufind-org:devfrom
rtloftus:overdrive-connector
Sep 10, 2026
Merged

Use config array instead of object for Overdrive connectors#5658
demiankatz merged 3 commits into
vufind-org:devfrom
rtloftus:overdrive-connector

Conversation

@rtloftus

@rtloftus rtloftus commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@demiankatz demiankatz changed the title Use config instead of array for Overdrive connectors Use config array instead of object for Overdrive connectors Sep 10, 2026

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rtloftus -- I'll take a closer look at this once the missing factory changes are added (see below).

Comment thread module/VuFind/src/VuFind/DigitalContent/OverdriveConnector.php
@rtloftus
rtloftus requested a review from demiankatz September 10, 2026 14:16

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rtloftus -- looks good, and tests are passing!

@demiankatz demiankatz added this to the 12.0 milestone Sep 10, 2026
@demiankatz demiankatz added the architecture pull requests that involve significant refactoring / architectural changes label Sep 10, 2026
@demiankatz
demiankatz merged commit 84fc809 into vufind-org:dev Sep 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

architecture pull requests that involve significant refactoring / architectural changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants