Use config array instead of object for Relais Connection module - #5657
Open
rtloftus wants to merge 5 commits into
Open
Use config array instead of object for Relais Connection module#5657rtloftus wants to merge 5 commits into
rtloftus wants to merge 5 commits into
Conversation
demiankatz
requested changes
Sep 10, 2026
demiankatz
left a comment
demiankatz
left a comment
Member
There was a problem hiding this comment.
Thanks, @rtloftus -- see below for one missing piece.
demiankatz
requested changes
Sep 10, 2026
demiankatz
left a comment
demiankatz
left a comment
Member
There was a problem hiding this comment.
Thanks, @rtloftus -- see below for a couple of finishing touches.
| public function placeRequest($oclc, $auth, $patron = null) | ||
| { | ||
| $uri = $this->config->addurl ?? null; | ||
| $uri = $this->config['addurl'] ?? null; |
Member
There was a problem hiding this comment.
Take a look at line 173 below -- I think there's one last object-style reference that still needs to be converted.
demiankatz
added
the
architecture
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.