Use config array instead of object for Blender Backend module - #5654
Open
rtloftus wants to merge 14 commits into
Open
Use config array instead of object for Blender Backend module#5654rtloftus wants to merge 14 commits into
rtloftus wants to merge 14 commits into
Conversation
rtloftus
changed the title
demiankatz
requested changes
Sep 9, 2026
demiankatz
left a comment
demiankatz
left a comment
Member
There was a problem hiding this comment.
Thanks for splitting this out, @rtloftus! See below for a couple of thoughts/next steps.
rtloftus
marked this pull request as draft
September 9, 2026 18:15
rtloftus
changed the title
rtloftus
marked this pull request as ready for review
September 10, 2026 15:17
rtloftus
changed the title
demiankatz
requested changes
Sep 10, 2026
demiankatz
left a comment
demiankatz
left a comment
Member
There was a problem hiding this comment.
Thanks, @rtloftus. The factory still needs to be updated; beyond that, see below for a few smaller points.
demiankatz
added
the
architecture
…Json/RecordCollection.php Co-authored-by: Demian Katz <demian.katz@villanova.edu>
…Json/RecordCollection.php Co-authored-by: Demian Katz <demian.katz@villanova.edu>
…Json/RecordCollection.php Co-authored-by: Demian Katz <demian.katz@villanova.edu>
demiankatz
requested changes
Sep 12, 2026
demiankatz
left a comment
demiankatz
left a comment
Member
There was a problem hiding this comment.
Thanks, @rtloftus -- I think we're nearly done here, but see below for a couple more things!
Comment on lines
+111
to
+112
| $backendConfig = $blenderConfig['Backends'] | ||
| ? $blenderConfig['Backends'] : []; |
Member
There was a problem hiding this comment.
This can be simplified:
Suggested change
| $backendConfig = $blenderConfig['Backends'] | |
| ? $blenderConfig['Backends'] : []; | |
| $backendConfig = $blenderConfig['Backends'] ?? []; |
| * | ||
| * @param \VuFind\Config\Config $config Configuration | ||
| * @param array $mappings Mappings configuration | ||
| * @param ?array $config Configuration |
Member
There was a problem hiding this comment.
Probably worth introducing property promotion here while we're changing types...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.