Use config array instead of object for Facet Recommend modules - #5645
Conversation
|
I'm not sure failing tests here have to do with the goal of this PR |
demiankatz
left a comment
There was a problem hiding this comment.
@rtloftus, I saw your comment about the failing test, so I focused on diagnosing that problem. I haven't reviewed the rest of your changes here yet, since I wasn't sure if you were completely done yet. Just let me know when you're ready and I'll take another look!
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @rtloftus -- see below for some additional work that's needed to get everything working here.
It may also be worth thinking about the scope of this PR. There are a lot of recommendation modules, so doing them all at once might get unwieldy. If we only do some, maybe it would make sense to do them in related batches -- for example, split this PR into separate ones for ConsortialVuFind, LibGuidesProfile, and facet-related recommendations. I don't mean to be a pest about breaking things apart, so if that's more work than it's worth, I don't mind finishing this up as-is, so long as we don't keep having to expand the scope until it becomes unwieldy. :-)
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @rtloftus, this looks good! I edited SideFacets.php to unwrap some lines to improve readability but made no functional changes there. I have one suggestion below which I will immediately apply. After that, I'll run tests and approve/merge if they pass!
No description provided.