Move action configuration to ActionConfigManager. - #5643
Open
EreMaijala wants to merge 4 commits into
Open
Conversation
- Actions are now configured based on action identifier instead of route name to avoid ambiquity caused by configurable default actions and duplicate routes. - Forwarding to an action also configures the action properly.
Adds an identifier for each config entry to make configs overridable in other modules.
EreMaijala
marked this pull request as ready for review
September 10, 2026 06:01
EreMaijala
commented
Sep 10, 2026
| * @link https://vufind.org Main Page | ||
| */ | ||
| interface AccessPermissionInterface | ||
| interface AccessPermissionInterface extends ActionConfigInterface |
Contributor
Author
There was a problem hiding this comment.
This kind of kills the usefulness of the interface check in the beginning of applyActionConfig because AbstractAction implements AccessPermissionInterface so in essence all actions are now configurable. But this is unavoidable if we want it to be possible for permissions to be applied to any action or group of actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.