Use config array instead of object for Facet Search Params - #5639
Merged
Conversation
demiankatz
requested changes
Sep 9, 2026
demiankatz
left a comment
Member
There was a problem hiding this comment.
If you change these traits, you will also have to change all of the calls to the modified methods in the classes that use them (in this case, \VuFind\Search\Solr\Params and \VuFind\Search\Summon\Params). You should be able to use the ->toArray() method to convert objects to arrays when calling the methods for now, so we can wrap up these changes and simplify the eventual work to get rid of the remaining objects in the Params classes.
For example, change:
$this->initFacetLimitsFromConfig($config->Results_Settings ?? null);
$this->initFacetRestrictionsFromConfig($config->Results_Settings ?? null);
to:
$resultsSettings = isset($config->Results_Settings) ? $config->Results_Settings->toArray() : null;
$this->initFacetLimitsFromConfig($resultsSettings);
$this->initFacetRestrictionsFromConfig($resultsSettings);
demiankatz
approved these changes
Sep 10, 2026
demiankatz
left a comment
Member
There was a problem hiding this comment.
Thanks, @rtloftus; looks good, and tests are passing!
rtloftus
added a commit
to rtloftus/vufind
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.