Use config array instead of object for Auth plugins by rtloftus · Pull Request #5620 · vufind-org/vufind

rtloftus · 2026-09-03T19:42:30Z

No description provided.

demiankatz

I would suggest splitting this up for easier review. All of the auth plugins need to be updated together, but the EmailAuthenticator, LoginTokenManager and plain Manager are each stand-alone classes that could be updated independently of the plugins. Depending on your preferences, you could either do a separate PR for each of these three things, or you could do all three of them together as a grouped "Auth utilities" PR.

Additionally, a little more work is needed to get all of the Auth plugins up to speed. For example, it doesn't look like AlmaDatabase is done (and that's just the first I found; there may be more). You may need to search the Auth namespace for $this->getConfig() calls along with plain $this->config references to find all the bits that need changing.

demiankatz

Now that #5637 is merged, you should merge dev back into this branch and remove the remaining Config object references from the setConfig call in \VuFind\Auth\Manager to align the signatures.

I'll review more carefully once everything is up to date here.

demiankatz

@rtloftus, I see you've re-requested a review, but there are no changes since the last review. Is it possible you forgot to push up your latest changes? (It looks to me like this still needs the dev branch merged into it, and the setConfig call in \VuFind\Auth\Manager updated to match the changed signature in the auth plugins).

…#5616)

…find-org#5617)

Co-authored-by: Demian Katz <demian.katz@villanova.edu>

Moves locale detection to LocaleSettings to simplify it and drop dependency on slm/locale that has not been updated for PHP 8.4+.

…-org#5618)

…ufind-org#5635)

Bumps [monolog/monolog](https://github.com/Seldaek/monolog) from 3.10.0 to 3.11.0. - [Release notes](https://github.com/Seldaek/monolog/releases) - [Changelog](https://github.com/Seldaek/monolog/blob/main/CHANGELOG.md) - [Commits](Seldaek/monolog@3.10.0...3.11.0) --- updated-dependencies: - dependency-name: monolog/monolog dependency-version: 3.11.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump libphonenumber-js from 1.13.8 to 1.13.11 Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.13.8 to 1.13.11. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/commits/v1.13.11) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-version: 1.13.10 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update vendor files via copyUpdatedDeps --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

)

Bumps [stripe/stripe-php](https://github.com/stripe/stripe-php) from 21.0.0 to 21.3.1. - [Release notes](https://github.com/stripe/stripe-php/releases) - [Changelog](https://github.com/stripe/stripe-php/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-php@v21.0.0...v21.3.1) --- updated-dependencies: - dependency-name: stripe/stripe-php dependency-version: 21.3.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Assisted-by: Sonnet 5 (Anthropic) Co-authored-by: Demian Katz <demian.katz@villanova.edu>

…nd-org#5621)

vufind-org#5631)

)

…ufind-org#5642) Co-authored-by: Demian Katz <demian.katz@villanova.edu>

…Ajax Handlers (vufind-org#5646)

…ufind-org#5653)

…ule (vufind-org#5652)

…g#5639)

…dule (vufind-org#5651)

…lete translations (vufind-org#5611)

…d-org#5645)

…org#5655)

demiankatz

See below for a solution to the current build failure mystery. :-)

demiankatz · 2026-09-10T16:29:16Z

 use Lmc\Rbac\Identity\IdentityInterface;
 use Lmc\Rbac\Mvc\Identity\IdentityProviderInterface;
 use Psr\Log\LoggerAwareInterface;
-use VuFind\Config\Config;


This is still being used on line 206 -- that's the reason the tests are failing.

rtloftus added 4 commits September 3, 2026 15:41

Use config array instead of object for Auth plugins

71379da

composer fix

5c0a492

update test

de19999

logintokenmanagertest

8980019

demiankatz requested changes Sep 6, 2026

View reviewed changes

rtloftus marked this pull request as draft September 8, 2026 14:25

rtloftus added 10 commits September 8, 2026 11:01

logintokenmanagertest

242c25a

emailauthenticatortest

7e21c77

managertest

1a65b99

managerfactory

1d8746b

logintokenmanagerfactory

d356131

emailauthenticatorfactory

28cf6b4

manager

24f412d

emailauthenticator

af668be

logintokenmanager

9abba25

almadatabase

f165d99

rtloftus requested a review from demiankatz September 8, 2026 15:22

rtloftus marked this pull request as ready for review September 8, 2026 15:22

demiankatz mentioned this pull request Sep 8, 2026

Use config array instead of object for Auth Utils #5637

Merged

demiankatz requested changes Sep 8, 2026

View reviewed changes

rtloftus requested a review from demiankatz September 9, 2026 16:03

demiankatz requested changes Sep 10, 2026

View reviewed changes

rtloftus and others added 8 commits September 10, 2026 10:48

Use config array instead of object in OAI Server code (vufind-org#5614)

68e998c

Use config array instead of object in OpenURL view helper (vufind-org…

e81a514

…#5616)

Use config array instead of object in AccountCapabilities service (vu…

f519c7e

…find-org#5617)

Eliminate use of intval in ProxyURL view helper (vufind-org#5619)

ed4e014

Co-authored-by: Demian Katz <demian.katz@villanova.edu>

Eliminate dependency on slm/locale. (vufind-org#5624)

8775658

Moves locale detection to LocaleSettings to simplify it and drop dependency on slm/locale that has not been updated for PHP 8.4+.

RateLimiter: Add minimal text to the Turnstile challenge page (vufind…

e8e53a2

…-org#5618)

Add unit tests for Collections browse actions. (vufind-org#5633)

69c0c60

Fix bug: language globals must initialize after language detection. (v…

44cb3de

…ufind-org#5635)

dependabot Bot and others added 26 commits September 10, 2026 10:48

Use config array instead of object for Auth Utils (vufind-org#5637)

960caa4

Add unit tests for Collections index browse. (vufind-org#5636)

50f8329

Use config array instead of object for Session Handlers (vufind-org#5640

441f7da

)

Refactor ErrorController to actions. (vufind-org#5533)

d01cbb7

Add Mink test for System/available setting. (vufind-org#5650)

861a889

Fix upgrading in subdirectories (vufind-org#5649)

3b97a93

Fix stale refreshOnClose when lightbox is closed (vufind-org#5647)

67f63f8

Fix arbitrary attributes flag in script rendering (vufind-org#5648)

101a171

Assisted-by: Sonnet 5 (Anthropic) Co-authored-by: Demian Katz <demian.katz@villanova.edu>

Use config array instead of object for WorldCat2 BackendFactory (vufi…

efc5f44

…nd-org#5621)

KohaRest: Fix status message code check for NotForLoan or Lost status. (

576ac47

vufind-org#5631)

Use config array instead of object on Sitemap Generator (vufind-org#5641

ccea50b

)

Use config array instead of object for ContentPages Sitemap plugin (v…

305b4eb

…ufind-org#5642) Co-authored-by: Demian Katz <demian.katz@villanova.edu>

Use config array instead of object on ResolverLinks and SystemStatus …

25a4688

…Ajax Handlers (vufind-org#5646)

Use config array instead of object for SimilarBuilder Backend module (v…

488570d

…ufind-org#5653)

Use config array instead of object for LibGuidesProfile Recommend mod…

43622d2

…ule (vufind-org#5652)

Use config array instead of object for Facet Search Params (vufind-or…

189323d

…g#5639)

Use config array instead of object for Consortial VuFind Recommend mo…

d61fd64

…dule (vufind-org#5651)

Add new translation key/string pair for export format and update obso…

6407fde

…lete translations (vufind-org#5611)

Use config array instead of object for Facet Recommend modules (vufin…

d98e35c

…d-org#5645)

Use config array instead of object for I18n module (vufind-org#5638)

c5797d9

Use config array instead of value in Interval Captcha module (vufind-…

872e4c2

…org#5655)

update manager setConfig func

9d4a7d6

Merge branch 'dev' into abstract-base-auth

fd4430a

demiankatz requested changes Sep 10, 2026

View reviewed changes

rtloftus added 2 commits September 10, 2026 12:34

wrap setConfig

6af3049

wrapped setconfig to array

1a62470

rtloftus requested a review from demiankatz September 10, 2026 18:41

Navigation Menu

Uh oh!

Use config array instead of object for Auth plugins - #5620

Use config array instead of object for Auth plugins#5620
rtloftus wants to merge 60 commits into
vufind-org:devfrom
rtloftus:abstract-base-auth

rtloftus commented Sep 3, 2026

Uh oh!

demiankatz left a comment

Uh oh!

demiankatz left a comment

Uh oh!

demiankatz left a comment

Uh oh!

demiankatz left a comment

Uh oh!

demiankatz Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

rtloftus commented Sep 3, 2026

Uh oh!

demiankatz left a comment

Choose a reason for hiding this comment

Uh oh!

demiankatz left a comment

Choose a reason for hiding this comment

Uh oh!

demiankatz left a comment

Choose a reason for hiding this comment

Uh oh!

demiankatz left a comment

Choose a reason for hiding this comment

Uh oh!

demiankatz Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants