Update for Solr 10 - #60
Open
stweil wants to merge 3 commits into
Open
Conversation
Solr 10 bundles Lucene 10, whose class files use Java records; compiling against them fails with --release 11. Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud) Signed-off-by: Stefan Weil <sw@weilnetz.de>
Lucene 10 turned TotalHits into a record, so the public value field is now accessed through a value() method. SolrJ 10 changed the SolrRequest API: the constructor now takes a SolrRequestType argument, getRequestType() returns the new SolrRequestType enum instead of a String, and createResponse() now receives the parsed NamedList instead of a SolrClient. Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud) Signed-off-by: Stefan Weil <sw@weilnetz.de>
3 tasks
Author
|
The CI build still uses Solr 9/Lucene 9 API. Therefore it fails. |
While the Solr 10 upgrade is pending in vufind-org/vufind (PR 5553), build against the corresponding pull request branch instead of vufind's dev branch, which still uses Solr 9. Solr 10 requires Java 21 or later, so raise the CI Java version from 17 to 21. Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud) Signed-off-by: Stefan Weil <sw@weilnetz.de>
Author
|
.github/workflows/ci.yaml now uses my own fork of VuFind to fix the CI test. This should be fixed as soon as upstream VuFind has support for Solr 10. |
Member
|
Thanks, @stweil -- I've added a TODO checklist about this so we don't forget to change it back when we're ready to merge this. I guess we should merge the VuFind PR first once everything is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: