Fix generic SFC findComponent types - #2934
Draft
simonyang08 wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2436
Summary
findComponentVueWrapperinstead of falling through toDOMWrapper<Node><script setup generic>componentsRoot cause
Generic SFCs emitted by Vue's
<script setup generic>syntax expose a generic call signature rather than the construct signature used byDefinedComponent. The existing overloads therefore selected the DOM-wrapper fallback.Compatibility
The new overload is limited to generic call signatures returning
VNode. Existing functional-component and defined-component overloads remain unchanged. The result intentionally uses an unparameterizedVueWrapperbecausefindComponentcannot instantiate the SFC's generic type parameter soundly.Validation
vue-tscreproduction - failed before, passed afterpnpm tsd- passedpnpm test --run tests/findComponent.spec.ts- 36 passedpnpm build- passedpnpm lint- passed with unrelated existing warningsgit diff --check- passedAI disclosure
This change was prepared with OpenAI Codex assistance and reviewed and validated locally by the contributor.