Add accessibility props to Button component#1457
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds accessibility properties to the Button component, enabling developers to set custom ARIA attributes for better screen reader support and accessibility compliance.
Key Changes:
- Added
roleandariaLabelprops to the Button component - Props are passed through to the rendered element with appropriate HTML attributes
- Updated PropTypes definitions with accessibility-focused documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| react/components/Button/index.js | Added role and ariaLabel props with PropTypes definitions and rendered as role and aria-label HTML attributes |
| CHANGELOG.md | Documented the new accessibility props in the Unreleased section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iago1501
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Adds
roleandariaLabelprops to the Button component for improved accessibility support.What problem is this solving?
Enables developers to set custom ARIA attributes on buttons for better screen reader compatibility and compliance with accessibility standards.
How should this be manually tested?
Add this code in
react/playground/Playground.tsx:Screenshots or example usage
The new props can be used as follows:
Inspect the rendered HTML to verify that
roleandaria-labelattributes are properly set. If props are not provided, the attributes will not be rendered.Types of changes