Add id to numeric stepper input#1454
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Hi @vsseixaso, could you please review this as a priority as it has been 2 weeks since I updated the associated PR. |
Contributor
Author
|
@vsseixaso Thanks for the details on the new feature flag. Have implemented it into both the PRs and is working on the workspace linked in the description. |
ArthurTriis1
approved these changes
Sep 29, 2025
matheusps
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This is the second of two PRs to solve a web accessibility issue for the NumberStepper input and associated label. The first PR is here: vtex-apps/product-quantity#68
This PR adds the id of "vtex-product-quantity-input" to the input element, which is labelled by the label element created in the first PR link above.
How to test it?
Check the HTML in developer console to see the changes reflected.
Workspace
Screenshots or example usage:
Screenshots or example usage
Types of changes