-
Notifications
You must be signed in to change notification settings - Fork 81
feat(core): add RecommendationShelf section with personalization tracking #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thiagopereira-vtex
wants to merge
30
commits into
dev
Choose a base branch
from
feat/recommendation-shelf
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
6c426a8
feat(core): add RecommendationShelf section with personalization trac…
thiagopereira-vtex 5f3999b
fix(core): add recommendation/personalization GraphQL typeDefs
thiagopereira-vtex 1f92187
test(core): include recommendation operations in schema assertions
thiagopereira-vtex 961112a
fix(api): expose recommendation and personalization operations
thiagopereira-vtex c0495e5
refactor(core): clean up RecommendationShelf code smells
thiagopereira-vtex 1108aa3
test(core): cover RecommendationShelf and useStartSession
thiagopereira-vtex 4caead7
refactor(core): compare globalThis.window with undefined directly
thiagopereira-vtex 70e3b83
Update packages/core/cms/faststore/components/cms_component__Recommen…
thiagopereira-vtex ec92aef
fix(api): use private cache scope for personalized recommendations
thiagopereira-vtex e369181
fix(core): harden RecommendationShelf per review feedback
thiagopereira-vtex fab2acc
refactor(core): move analytics utils out of RecommendationShelf into SDK
thiagopereira-vtex 91e14d0
refactor(core): reuse SDK GraphQL layer in RecommendationShelf
thiagopereira-vtex 402816e
feat(core): make RecommendationShelf carousel and product card config…
thiagopereira-vtex 4658ec0
refactor(core): remove SendProductViewEvent mutation and related logic
thiagopereira-vtex 814da62
refactor(core): simplify RecommendationShelf per quality review
thiagopereira-vtex 4c934e8
refactor(api): remove SendProductViewEvent mutation and related types
thiagopereira-vtex f3ef796
refactor(api, core): rename startSession to startRecommendationSessio…
thiagopereira-vtex 1ea6afa
feat(api, core): return StoreProduct from recommendations for consist…
thiagopereira-vtex 3a52956
refactor(api): rename StartSessionResult to StartRecommendationSessio…
thiagopereira-vtex 7b4e2d2
feat(core): enhance RecommendationShelf with configurable items conte…
thiagopereira-vtex 6ea9e5f
Update packages/api/src/platforms/vtex/clients/recommendation/index.ts
thiagopereira-vtex 060d0a0
feat(api, core): implement server-side validation for recommendations…
thiagopereira-vtex 3214947
feat(core): add RecommendationShelf component for personalized produc…
thiagopereira-vtex acb4bf4
refactor(RecommendationShelf): update prop type and improve empty sta…
thiagopereira-vtex daa57c5
refactor(api, core): address recommendation shelf review feedback
thiagopereira-vtex 9de413f
test(api, core): cover recommendation resolvers/client and fix Sonar …
thiagopereira-vtex a43bf23
refactor(core): use Boolean directly as the default retry predicate
thiagopereira-vtex d89732b
Merge branch 'dev' into feat/recommendation-shelf
thiagopereira-vtex 1852ee1
fix(api): close Recommendation describe block after merge with dev
thiagopereira-vtex 0e36d26
fix(api): add storeCookies option to fetchAPI for recommendations
thiagopereira-vtex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -470,6 +470,15 @@ type Query { | |
| Returns the items in an orderForm by its ID. | ||
| """ | ||
| orderFormItems(orderFormId: String!): [StoreOrderFormCartItem!]! @auth | ||
| """ | ||
| Returns personalized product recommendations for a given campaign. | ||
| """ | ||
| recommendations( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is the implementation for this recommendations query? |
||
| campaignVrn: String! | ||
| userId: String | ||
| products: [String!] | ||
| ): RecommendationResponse! | ||
| @cacheControl(scope: "public", sMaxAge: 120, staleWhileRevalidate: 3600) | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| type ValidateUserData { | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.