Skip to content

feat: replace pagetype with by-linkid cascade + localized PLP/collection pages#3401

Open
hellofanny wants to merge 29 commits into
feat/localized-slugs-linksfrom
feat/localized-collection-pages
Open

feat: replace pagetype with by-linkid cascade + localized PLP/collection pages#3401
hellofanny wants to merge 29 commits into
feat/localized-slugs-linksfrom
feat/localized-collection-pages

chore: Extracts typed helpers in collection and product resolvers

c12e1f8
Select commit
Loading
Failed to load commit list.
Sonar - Workflows / SonarQube Code Analysis failed Jul 3, 2026 in 34s

Quality Gate failed

Failed Quality Gate failed

  • 11 New Issues (is greater than 0)
  • 55.90% Coverage on New Code (is less than 75.00%)

Project ID: vtex_faststore_f0a862d5-9557-49f9-8d09-de40caa76622

View in SonarQube

Annotations

Check notice on line 40 in packages/core/src/sdk/localization/LocalizedProductContext.tsx

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/core/src/sdk/localization/LocalizedProductContext.tsx#L40

Mark the props of the component as read-only.

Check notice on line 305 in packages/core/src/sdk/localization/useBindingSelector.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/core/src/sdk/localization/useBindingSelector.ts#L305

Prefer `globalThis` over `window`.

Check notice on line 312 in packages/core/src/sdk/localization/useBindingSelector.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/core/src/sdk/localization/useBindingSelector.ts#L312

Prefer `globalThis` over `window`.

Check notice on line 311 in packages/core/src/sdk/localization/useBindingSelector.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/core/src/sdk/localization/useBindingSelector.ts#L311

Prefer `globalThis` over `window`.

Check notice on line 305 in packages/core/src/sdk/localization/useBindingSelector.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/core/src/sdk/localization/useBindingSelector.ts#L305

Prefer `globalThis` over `window`.

Check notice on line 305 in packages/core/src/sdk/localization/useBindingSelector.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/core/src/sdk/localization/useBindingSelector.ts#L305

Prefer `globalThis` over `window`.

Check notice on line 20 in packages/api/src/platforms/vtex/clients/commerce/types/ByLinkId.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/api/src/platforms/vtex/clients/commerce/types/ByLinkId.ts#L20

Complete the task associated to this "TODO" comment.

Check notice on line 31 in packages/api/src/platforms/vtex/clients/commerce/types/ByLinkId.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/api/src/platforms/vtex/clients/commerce/types/ByLinkId.ts#L31

Complete the task associated to this "TODO" comment.

Check notice on line 8 in packages/api/src/platforms/vtex/clients/commerce/types/ByLinkId.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/api/src/platforms/vtex/clients/commerce/types/ByLinkId.ts#L8

Complete the task associated to this "TODO" comment.

Check failure on line 111 in packages/api/src/platforms/vtex/resolvers/query.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/api/src/platforms/vtex/resolvers/query.ts#L111

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.

Check notice on line 128 in packages/api/src/platforms/vtex/resolvers/collection.ts

See this annotation in the file changed.

@sonar-workflows sonar-workflows / SonarQube Code Analysis

packages/api/src/platforms/vtex/resolvers/collection.ts#L128

Unexpected negated condition.