Skip to content

use confine for facts - #1090

Merged
d1nuc0m merged 1 commit into
voxpupuli:masterfrom
cirrax:dev_cirrax
Oct 12, 2026
Merged

d1nuc0m merged 1 commit into
voxpupuli:masterfrom
cirrax:dev_cirrax

Conversation

@trefzer

@trefzer trefzer commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@bastelfreak bastelfreak added the enhancement New feature or request label Sep 22, 2026
Comment thread lib/facter/erl_ssl_path.rb Resolved
@trefzer trefzer changed the title replace Facter::Util::Resolution.which (deprecated) + lint_fix use confine for facts Sep 23, 2026
@trefzer
trefzer force-pushed the dev_cirrax branch 2 times, most recently from 5bcc3d9 to 965a66d Compare September 23, 2026 12:03
@trefzer
trefzer requested a review from bastelfreak September 23, 2026 12:20
@bastelfreak

Copy link
Copy Markdown
Member

@d1nuc0m can you review this PR? @trefzer can you rebase please?

@d1nuc0m

d1nuc0m commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Ok, @trefzer do not spend time on rabbitmqadmin based facts as I'm reworking them

@trefzer trefzer closed this Oct 10, 2026
@d1nuc0m

d1nuc0m commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

@trefzer sorry, I didn't mean the PR had to be closed 😅
Changes are fine as long as on facts that use rabbitmqctl (anything apart from rabbitmq version basically in this PR)

@d1nuc0m d1nuc0m reopened this Oct 11, 2026
@trefzer

trefzer commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

@d1nuc0m ah ok, so I was a bit fast with closing... rebased, should be mergable now without version.

@trefzer
trefzer requested a review from d1nuc0m October 11, 2026 19:15
@d1nuc0m
d1nuc0m merged commit c6f7307 into voxpupuli:master Oct 12, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants