Skip to content

chart: enable workloadmanager auth#433

Open
avinxshKD wants to merge 1 commit into
volcano-sh:mainfrom
avinxshKD:fix/workloadmanager-enable-auth
Open

chart: enable workloadmanager auth#433
avinxshKD wants to merge 1 commit into
volcano-sh:mainfrom
avinxshKD:fix/workloadmanager-enable-auth

Conversation

@avinxshKD

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

Enables WorkloadManager auth in the base chart. The chart already has Router call WorkloadManager with its service account token, but WorkloadManager was not started with --enable-auth.

Also grants Router the minimal sandbox create/delete RBAC needed once WorkloadManager starts using the caller token.

Which issue(s) this PR fixes:
Fixes #432

Special notes for your reviewer:

Helm is not installed in my local env, so I could not run helm template or helm lint. I did run git diff --cached --check before committing.

Does this PR introduce a user-facing change?:

Base chart now enables WorkloadManager auth by default.

Copilot AI review requested due to automatic review settings July 9, 2026 10:51
@volcano-sh-bot volcano-sh-bot added the kind/bug Something isn't working label Jul 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hzxuzhonghu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces authentication configuration for the AgentCube Workload Manager, enabling the --enable-auth flag and setting up RBAC permissions for the router service account to manage sandboxes and sandboxclaims. The review feedback recommends replacing the proposed ClusterRole and ClusterRoleBinding with namespace-scoped Role and RoleBinding resources to adhere to the principle of least privilege and prevent naming conflicts in multi-namespace deployments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread manifests/charts/base/templates/rbac-router.yaml Outdated
@avinxshKD

Copy link
Copy Markdown
Author

small chart-side fix for this. Found that just passing --enable-auth was not enough, since WorkloadManager uses the caller token after auth is enabled. Added the minimal fix

@acsoto @JesseStutler PTAL, when get chance.

@codecov-commenter

codecov-commenter commented Jul 9, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.50%. Comparing base (524e55e) to head (6bde635).
⚠️ Report is 176 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #433       +/-   ##
===========================================
+ Coverage   47.57%   58.50%   +10.93%     
===========================================
  Files          30       36        +6     
  Lines        2819     3463      +644     
===========================================
+ Hits         1341     2026      +685     
+ Misses       1338     1228      -110     
- Partials      140      209       +69     
Flag Coverage Δ
unittests 58.50% <ø> (+10.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Avinash Kumar Deepak <avinash8655279@gmail.com>
Copilot AI review requested due to automatic review settings July 9, 2026 11:00
@avinxshKD avinxshKD force-pushed the fix/workloadmanager-enable-auth branch from 88c3527 to 6bde635 Compare July 9, 2026 11:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workloadmanager chart does not enable auth

4 participants