Skip to content

get thumbnail title and description #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
350d wants to merge 3 commits into
base: master
Choose a base branch
from
Open

get thumbnail title and description #103

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
198e7db
get thumbnail title and description
350d Jul 6, 2016
1d59b3a
Check post_id is valid
350d Jul 7, 2016
dadcc82
Defaults for post id, attachment excerpt and title
350d Jul 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions multi-post-thumbnails.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,32 @@ public static function get_post_thumbnail_url($post_type, $id, $post_id = 0, $si

return $url;
}

/**
*
* @param string $post_type The post type.
* @param string $id The id used to register the thumbnail.
* @return thumbnail title.
*/
public static function get_post_thumbnail_title($post_type, $id) {
$post_id = get_the_ID();
$post_thumbnail_id = self::get_post_thumbnail_id($post_type, $id, $post_id);
$attachment_meta = get_post($post_thumbnail_id);

@chrisscott chrisscott Jul 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you check to make sure $post_thumbnail_id is valid here before doing get_post()? Making sure it is an int greater than zero should cover it. If it isn't valid, returning a blank string seems appropriate.

return $attachment_meta->post_title;
}

/**
*
* @param string $post_type The post type.
* @param string $id The id used to register the thumbnail.
* @return thumbnail description.
*/
public static function get_post_thumbnail_description($post_type, $id) {
$post_id = get_the_ID();
$post_thumbnail_id = self::get_post_thumbnail_id($post_type, $id, $post_id);
$attachment_meta = get_post($post_thumbnail_id);

@chrisscott chrisscott Jul 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like above an you check to make sure $post_thumbnail_id is valid here before doing get_post() and returning a blank string if not?

return $attachment_meta->post_excerpt;

@chrisscott chrisscott Jul 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use get_the_excerpt() here? It would apply the excerpt filters which seems appropriate as well as check for private posts to prevent information disclosure where it isn't desired. If so, this would negate my comment above.

}

/**
* Output the post thumbnail HTML for the metabox and AJAX callbacks
Expand Down