aide 0.19-3: require libgcrypt >= 1.10.4 on subrelease 91+ - #1670
Open
dcasota wants to merge 1 commit into
Open
Conversation
aide links against libgcrypt but only carried an unversioned "Requires: libgcrypt". On subrelease 91 and above the installer therefore had to name libgcrypt explicitly in KS_STIG_PACKAGES to guarantee a new enough copy on the media - a workaround in the installer for a packaging gap here. Add a versioned Requires guarded by photon_subrelease so sub-90 keeps the unversioned dependency and 91+ gets the floor. Verified with rpmspec: subrelease 90 emits "libgcrypt", subrelease 92 emits "libgcrypt >= 1.10.4", zero warnings in both. This is the counterpart to dropping libgcrypt from KS_STIG_PACKAGES in photon-os-installer 2.8-5. Change-Id: I470332467212b2dac2fbbb84ac05158531a71a13 Signed-off-by: Daniel Casota <dcasota@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the packaging gap that photon-os-installer was working around.
Problem
aidelinks against libgcrypt but declares only an unversionedRequires: libgcrypt. Because nothing pinned a floor,stigenable.pylistedlibgcryptexplicitly inKS_STIG_PACKAGESpurely to guarantee a new enough copy reached the install media — an installer-side workaround for a spec-side omission.Change
A
photon_subrelease-guarded versioned dependency:Release 2 → 3.
Verification
rpmspecon both sides of the guard:libgcryptlibgcrypt >= 1.10.4Zero warnings in both cases;
support/spec-checker/check_spec.pyexits 0.Related
Counterpart to #19, which drops
libgcryptfromKS_STIG_PACKAGESnow that the dependency is expressed where it belongs. Verified on a live install: libgcrypt-1.10.4-2 still lands on the media and on the installed system as an ordinary transitive dependency of aide.