Skip to content

fix: do not require all nics to have an ip - #720

Draft
tenthirtyam wants to merge 1 commit into
mainfrom
fix/do-not-require-all-nics-to-have-an-ip
Draft

fix: do not require all nics to have an ip#720
tenthirtyam wants to merge 1 commit into
mainfrom
fix/do-not-require-all-nics-to-have-an-ip

Conversation

@tenthirtyam

@tenthirtyam tenthirtyam commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add optional ip_wait_adapter_index on vsphere-iso and vsphere-clone for environments where multiple NICs may receive routable addresses.

Type

  • fix: Bug Fix
  • feat: Feature or Enhancement
  • docs: Documentation
  • refactor: Refactoring
  • chore: Build, Dependencies, Workflows, etc.
  • other: Other (Please describe.)

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Tests

  • Tests have been added or updated.
  • Tests have been completed.

Output:

Documentation

  • Documentation has been added or updated.

Issue References

Closes #133

Release Note

Additional Information

@tenthirtyam tenthirtyam added this to the v2.2.0 milestone May 22, 2026
@tenthirtyam tenthirtyam self-assigned this May 22, 2026
@tenthirtyam
tenthirtyam requested a review from a team as a code owner May 22, 2026 16:39
@tenthirtyam tenthirtyam added the enhancement Enhancement label May 22, 2026
@github-actions github-actions Bot added documentation Documentation needs-review Needs Review size/l Relative Sizing: Large labels May 22, 2026
@tenthirtyam
tenthirtyam force-pushed the fix/do-not-require-all-nics-to-have-an-ip branch 2 times, most recently from b507229 to 43029ac Compare May 26, 2026 16:06
@tenthirtyam tenthirtyam changed the title fix: do not require all nics to have an ip [wip] fix: do not require all nics to have an ip May 26, 2026
@tenthirtyam tenthirtyam modified the milestones: v2.2.0, v2.y.z May 26, 2026
@tenthirtyam
tenthirtyam marked this pull request as draft May 26, 2026 19:42
@tenthirtyam tenthirtyam added the do-not-merge Do Not Merge label May 26, 2026
@tenthirtyam

Copy link
Copy Markdown
Collaborator Author

Moving this back to draft and updating the milestone as the the changes are not yet working as expected.

@tenthirtyam tenthirtyam removed the needs-review Needs Review label May 26, 2026
@tenthirtyam
tenthirtyam force-pushed the fix/do-not-require-all-nics-to-have-an-ip branch from 43029ac to c078121 Compare June 23, 2026 21:00
@github-actions github-actions Bot added the needs-review Needs Review label Jun 23, 2026
@tenthirtyam
tenthirtyam force-pushed the fix/do-not-require-all-nics-to-have-an-ip branch 2 times, most recently from ec910c3 to 8bc1b82 Compare July 8, 2026 14:43
@tenthirtyam
tenthirtyam force-pushed the fix/do-not-require-all-nics-to-have-an-ip branch from 8bc1b82 to 2b72a5f Compare July 9, 2026 17:32
@tenthirtyam
tenthirtyam force-pushed the fix/do-not-require-all-nics-to-have-an-ip branch 4 times, most recently from 843c34e to e888525 Compare July 17, 2026 20:02
@tenthirtyam
tenthirtyam force-pushed the fix/do-not-require-all-nics-to-have-an-ip branch 3 times, most recently from cdd7312 to 3113a28 Compare July 25, 2026 18:18
@tenthirtyam
tenthirtyam force-pushed the fix/do-not-require-all-nics-to-have-an-ip branch 2 times, most recently from 0463610 to e83bb52 Compare August 4, 2026 13:30
Copilot AI lite review requested due to automatic review settings August 4, 2026 13:30

This comment was marked as resolved.

@tenthirtyam
tenthirtyam force-pushed the fix/do-not-require-all-nics-to-have-an-ip branch 6 times, most recently from 332a7ae to e3496b0 Compare August 12, 2026 20:37
@github-actions github-actions Bot added the size/xl Relative Sizing: Extra-Large label Aug 12, 2026
@tenthirtyam tenthirtyam modified the milestones: v2.y.z, v2.5.0 Aug 12, 2026
Add optional ip_wait_adapter_index on vsphere-iso and vsphere-clone for
environments where multiple NICs may receive routable addresses.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam
tenthirtyam force-pushed the fix/do-not-require-all-nics-to-have-an-ip branch from e3496b0 to 88a5779 Compare August 12, 2026 23:24
@tenthirtyam tenthirtyam changed the title [wip] fix: do not require all nics to have an ip fix: do not require all nics to have an ip Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Do Not Merge documentation Documentation enhancement Enhancement needs-review Needs Review size/l Relative Sizing: Large size/xl Relative Sizing: Extra-Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vsphere-iso: multiple NICs; only one NIC with IP reachability

2 participants