Skip to content

glib_stubs: avoid GLib g_free macro redefinition error - #779

Open
kraj wants to merge 1 commit into
vmware:masterfrom
kraj:kraj/glib-2.0
Open

glib_stubs: avoid GLib g_free macro redefinition error#779
kraj wants to merge 1 commit into
vmware:masterfrom
kraj:kraj/glib-2.0

Conversation

@kraj

@kraj kraj commented Nov 21, 2025

Copy link
Copy Markdown

glib 2.78+ defines g_free as an object-size checking macro. open-vm-tools overrides g_free(), leading to preprocessor expansion inside the function signature and breaking the build.

Undefine the macro before defining the stub.

Upstream-Status: Pending

glib 2.78+ defines g_free as an object-size checking macro.
open-vm-tools overrides g_free(), leading to preprocessor expansion
inside the function signature and breaking the build.

Undefine the macro before defining the stub.

Upstream-Status: Pending
Signed-off-by: Khem Raj <raj.khem@gmail.com>
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Jun 16, 2026
While here, fix build with recent glib versions [1]

Obtained from:	vmware/open-vm-tools#779 [1]
Sponsored by:	Rubicon Communications, LLC ("Netgate")
camachat pushed a commit to camachat/freebsd-ports that referenced this pull request Jul 22, 2026
While here, fix build with recent glib versions [1]

Obtained from:	vmware/open-vm-tools#779 [1]
Sponsored by:	Rubicon Communications, LLC ("Netgate")
camachat pushed a commit to camachat/freebsd-ports that referenced this pull request Jul 24, 2026
While here, fix build with recent glib versions [1]

Obtained from:	vmware/open-vm-tools#779 [1]
Sponsored by:	Rubicon Communications, LLC ("Netgate")
@legal-compliance-bot

Copy link
Copy Markdown

🛑 Legal Compliance Check Failed

Hi @kraj, thank you for your contribution!

To merge this Pull Request, you must sign our CLA.

Note: Even if you signed off your commits locally (using git commit -s), you must post the comment below to register your signature with our automated system.
Note: This is a one-time process. Once signed, future contributions to this repository will be verified automatically.

1. Read the Document: Click here to read the CLA
2. Sign via Comment: Copy and paste the exact line below into a new comment on this Pull Request:

I have read the CLA Document and I hereby sign the CLA for this and all future contributions.

⏳ Processing Schedule:
Our 'Compliance Sweeper' runs automatically approximately every 15-20 minutes.
After you post the comment, your status will update automatically during the next scheduled run.
You do not need to take any further action.

@legal-compliance-bot

Copy link
Copy Markdown

Hi @kraj,

🔄 System Migration: Compliance Verified

We have migrated this repository to a new automated compliance system.
We verified your status during the migration and marked this Pull Request as Compliant (CLA/DCO Signed).

🛑 Troubleshooting (If Blocked):
If your Merge button is currently blocked waiting for a 'Required Workflow' or 'Status Check', GitHub requires a new event to register the pass. Please choose one of the following options to trigger the update:

Option 1 (Command Line): Push an empty commit.
git commit --allow-empty -m 'trigger checks' && git push

Option 2 (Web UI): Simply Close and immediately Reopen this Pull Request using the buttons at the bottom of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant