[Draft]remove computed_field from total_tokens#448
Draft
tukwila wants to merge 2 commits into
Draft
Conversation
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
Contributor
Author
|
@markurtz please help to check this fix, i'm not sure if @computed_field can be remove from total_token to let xfail case: test_encode_decode_generative pass. |
Collaborator
|
No this is not a valid solution, total_tokens is a computed field. If the test is failing due to that decorator then its something wrong with the test. I think @jaredoconnell ran into a similar issue somewhere. |
Collaborator
|
Yeah. I believe that this is a bug or something where the cached value AND the processed value are both present. I didn't find a good solution previously. |
tukwila
changed the title
Contributor
Author
Got, pending this fix. |
3 tasks
mergify Bot
pushed a commit
that referenced
this pull request
Jun 24, 2026
## Summary See the linked issue for more details. In short, fields with the`@computed_field` decorator are included in `model_dump` (and similar) by default, but are then treated as extra fields when passed to `model_validate`, leading to duplicates appearing in the final deserialized object. ## Details - Set `exclude_computed_fields=True` in `Serializer.to_dict_pydantic` and `.to_sequence_pydantic` - Remove pytest.mark.xfail from `test_encode_decode_generative` ## Test Plan `tox -e test-unit -- tests/unit/utils/test_encoding.py` ## Related Issues - Resolves #446 - Alternative solution to #448 --- - [x] "I certify that all code in this PR is my own, except as noted below." ## Use of AI - [ ] Includes code generated or substantially modified by an AI agent - [ ] Includes tests generated or substantially modified by an AI agent > NOTE: the `Generated-by` or `Assisted-by` trailers should be used in git commit messages when code or tests were generated or substantially modified by an AI agent, as described in the project's [`DEVELOPING.md`](https://github.com/vllm-project/guidellm/blob/main/DEVELOPING.md) file. --- # git log commit 4c59acb Author: SkiHatDuckie <SkiHatDuckie@gmail.com> Date: Wed Jun 24 15:02:04 2026 -0400 Exclude computed fields during pydantic model dump Signed-off-by: SkiHatDuckie <SkiHatDuckie@gmail.com> --------- Signed-off-by: SkiHatDuckie <SkiHatDuckie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
To fix: #446
test cmd:
tox -e test -- --runxfail tests/unit/utils/test_encoding.py::TestMessageEncoding::test_encode_decode_generative
Test Plan
Related Issues
Use of AI
## WRITTEN BY AI ##)