fix(snapshot): support no-unsafe-eval CSP by evaluating snapshot files outside the tester#10665
Draft
hi-ogawa wants to merge 1 commit into
Draft
fix(snapshot): support no-unsafe-eval CSP by evaluating snapshot files outside the tester#10665hi-ogawa wants to merge 1 commit into
hi-ogawa wants to merge 1 commit into
Conversation
…s outside the tester Add an optional `readSnapshotFileData` to `SnapshotEnvironment` so environments that cannot evaluate snapshot content in the test runtime (e.g. the browser under a `no-unsafe-eval` CSP) can evaluate it elsewhere. `SnapshotState.create` provides the general default inline: it reads and evaluates the file in the current runtime when the environment does not implement the method. The browser is the only environment that overrides it, delegating to the server over RPC. Replace the silent `getSnapshotData` eval with `evaluateSnapshotFile`, which throws a hard error on corrupted snapshot files instead of swallowing it. Co-authored-by: OpenCode (claude-opus-4-8) <noreply@opencode.ai>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getSnapshotDataswallows the parse error, making snapshot failures impossible to debug #10615pushing changes before I (and agent) forget my review context of #10646
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.