Skip to content

perf(ssr): only record import-binding identifiers in ssrTransform #22720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shulaoda wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Draft

perf(ssr): only record import-binding identifiers in ssrTransform #22720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/vite/src/node/ssr/ssrTransform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ async function ssrTransformScript(
}

// 3. convert references to import bindings & import.meta references
walk(ast, {
walk(ast, idToImportMap, {
onStatements(statements) {
// ensure ";" between statements
for (let i = 0; i < statements.length - 1; i++) {
Expand Down Expand Up @@ -451,6 +451,7 @@ const isNodeInPattern = (node: ESTree.Node): node is ESTreeProperty =>
*/
function walk(
root: ESTree.Node,
idToImportMap: Map<string, string>,
{ onIdentifier, onImportMeta, onDynamicImport, onStatements }: Visitors,
) {
const parentStack: ESTree.Node[] = []
Expand Down Expand Up @@ -541,6 +542,7 @@ function walk(

if (node.type === 'Identifier') {
if (
idToImportMap.has(node.name) &&
!isInScope(node.name, parentStack) &&
isRefIdentifier(node, parent!, parentStack)
) {
Expand Down