perf(hmr): avoid eager subChain allocation in propagateUpdate#22719
Draft
shulaoda wants to merge 1 commit into
Draft
perf(hmr): avoid eager subChain allocation in propagateUpdate#22719shulaoda wants to merge 1 commit into
shulaoda wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
propagateUpdate,subChainwas allocated at the top of the importer loop for every importer, but it is only used in two branches.Problem
const subChain = currentChain.concat(importer)runs for every importer edge during HMR propagation.acceptedHmrDepsbranch and the recursive call. TheacceptedHmrExportsbranchcontinues without ever using it — so for modules accepted via export bindings (e.g. barrel/re-export files with many importers), each allocation is immediately discarded.Fix
currentChain.concat(importer)at the two sites that actually use it, so the export-acceptingcontinuepath allocates nothing. The two sites are mutually exclusive, so this computes the chain at most once per importer. No behavior change.Tests
propagateUpdatecorrectness remains covered by the existing HMR tests and theplayground/hmre2e suite.