fix(css): inject inlined CSS after the shebang line by shulaoda · Pull Request #22717 · vitejs/vite

shulaoda · 2026-06-19T11:39:56Z

For es-format chunks that start with a shebang, injectInlinedCSS inserted the CSS-injection code into the shebang line instead of after it.

Problem

The injection point was set to the index of the first \n, and s.appendRight(index, ...) inserts before that character — i.e. at the end of the shebang line.
Result for #!/usr/bin/env node\n<body>: #!/usr/bin/env nodeinjectCSS();\n<body>.
This breaks two things at once:
- The shebang line no longer points at a valid interpreter, so the file is no longer executable.
- JS treats the leading #!... line as a hashbang comment, so the appended injection code is dropped — the inlined CSS is never injected.
The no-newline fallback (= 0) was also wrong: it prepended the code before the shebang.

Inject after the shebang's newline (newlinePos + 1), matching how importAnalysisBuild.ts handles the same case (indexOf('\n') + 1).
When the shebang has no trailing newline, append \n + the injection so the shebang stays on its own line.

Added es-format cases for: shebang, no shebang (regression guard), and shebang without a trailing newline. The shebang cases fail without this change and pass with it.

fix(css): inject inlined CSS after the shebang line

7c3b21f

shulaoda requested review from sapphi-red and removed request for sapphi-red June 19, 2026 11:40

shulaoda marked this pull request as draft June 19, 2026 12:28

shulaoda marked this pull request as ready for review June 19, 2026 13:00

sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) feat: css labels Jun 30, 2026

bluwy approved these changes Jun 30, 2026

View reviewed changes