fix(css): inject inlined CSS after the shebang line#22717
Open
shulaoda wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
es-format chunks that start with a shebang,injectInlinedCSSinserted the CSS-injection code into the shebang line instead of after it.Problem
\n, ands.appendRight(index, ...)inserts before that character — i.e. at the end of the shebang line.#!/usr/bin/env node\n<body>:#!/usr/bin/env nodeinjectCSS();\n<body>.#!...line as a hashbang comment, so the appended injection code is dropped — the inlined CSS is never injected.= 0) was also wrong: it prepended the code before the shebang.Fix
newlinePos + 1), matching howimportAnalysisBuild.tshandles the same case (indexOf('\n') + 1).\n+ the injection so the shebang stays on its own line.Tests
es-format cases for: shebang, no shebang (regression guard), and shebang without a trailing newline. The shebang cases fail without this change and pass with it.