Fix silently-broken PHP 8.6 redis build#185
Merged
Merged
Conversation
phpredis git master started calling zend_bin2hex(), a Zend API only added in PHP 8.6.0alpha2, while builds were pinned to the older 8.6.0alpha1 base image. The compile failure went unnoticed because the git-source install blocks (redis, igbinary, mailparse, imagick) chained their build steps with a trailing `;` instead of `&&` before writing the extension ini file, so a failed `make` didn't stop the script from still enabling the (non-existent) extension. - Bump the 8.6 base image to 8.6.0alpha2, which now provides zend_bin2hex(). - Pin phpredis to a commit verified to build against it, since its unpinned HEAD tracks php-src's development branch closely. - Chain each git-source build fully through the ini write with &&, so a failed build now aborts the script instead of silently continuing.
Rely on the alpha2 base bump plus the fail-fast && chain instead of pinning to a specific commit.
eiriksm
enabled auto-merge (squash)
July 18, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.