Disable pi thinking for DeskTalk agent sessions

packages/core/src/services/ai/pi-session-service.test.ts

@@ -1,7 +1,11 @@
-import { describe, expect, it } from 'vitest';
+import { afterEach, describe, expect, it, vi } from 'vitest';
 import type { AssistantMessage, ToolCall } from '@mariozechner/pi-ai';
 import { PiSessionService, scrubHtmlToolCallArgs, summarizeHtml } from './pi-session-service';
 
+afterEach(() => {
+  vi.restoreAllMocks();
+});
+
 describe('summarizeHtml', () => {
   it('summarizes title, card count, and headings', () => {
     const html = [
@@ -233,3 +237,35 @@ describe('PiSessionService.getProviderOptions', () => {
     });
   });
 });
+
+describe('pi thinking defaults', () => {
+  it('reapplies thinking off when syncing provider preferences', async () => {
+    const targetModel = { provider: 'openai', id: 'gpt-5' };
+    const setModel = vi.fn();
+    const setThinkingLevel = vi.fn();
+
+    await PiSessionService.prototype['syncPreferences'].call({
+      resourceLoader: { reload: async () => {} },
+      syncProviderCredentials: async () => {},
+      getPreference: async (key: string) => {
+        if (key === 'ai.defaultProvider') {
+          return 'openai';
+        }
+        return undefined;
+      },
+      modelRegistry: {
+        find: (provider: string, model: string) =>
+          provider === 'openai' && model === 'gpt-5' ? targetModel : undefined,
+        getAvailable: () => [targetModel],
+      },
+      session: {
+        model: { provider: 'openai', id: 'gpt-4o' },
+        setModel,
+        setThinkingLevel,
+      },
+    });
+
+    expect(setModel).toHaveBeenCalledWith(targetModel);
+    expect(setThinkingLevel).toHaveBeenCalledWith('off');
+  });
+});

packages/core/src/services/ai/pi-session-service.ts

@@ -14,6 +14,7 @@ import {
   SessionManager,
   type AgentSession,
   type AgentSessionEvent,
+  type CreateAgentSessionOptions,
   type SessionInfo,
   type ToolDefinition,
 } from '@mariozechner/pi-coding-agent';
@@ -155,6 +156,20 @@ type BasicToolResultMessage = {
   timestamp: number;
 };
 
+const DESKTALK_PI_THINKING_LEVEL = 'off' as const;
+
+function disableSessionThinking(session: Pick<AgentSession, 'setThinkingLevel'>): void {
+  session.setThinkingLevel(DESKTALK_PI_THINKING_LEVEL);
+}
+
+async function createDeskTalkAgentSession(
+  options: CreateAgentSessionOptions,
+): Promise<AgentSession> {
+  const { session } = await createAgentSession(options);
+  disableSessionThinking(session);
+  return session;
+}
+
 function isUserMessage(message: BasicAgentMessage): message is BasicUserMessage {
   return message.role === 'user';
 }
@@ -697,7 +712,7 @@ export class PiSessionService {
       }),
     ];
 
-    const { session } = await createAgentSession({
+    const session = await createDeskTalkAgentSession({
       cwd: process.cwd(),
       authStorage,
       modelRegistry,
@@ -731,7 +746,7 @@ export class PiSessionService {
   }
 
   private async createSessionWithManager(sessionManager: SessionManager): Promise<AgentSession> {
-    const { session } = await createAgentSession({
+    const session = await createDeskTalkAgentSession({
       cwd: this.cwd,
       authStorage: this.authStorage,
       modelRegistry: this.modelRegistry,
@@ -1088,6 +1103,8 @@ export class PiSessionService {
     ) {
       await this.session.setModel(targetModel);
     }
+
+    disableSessionThinking(this.session);
   }
 
   private saveMessageMetadata(