fix: prevent internal server error when saving expectations on ready repo#179
Open
joshjon wants to merge 1 commit into
Open
fix: prevent internal server error when saving expectations on ready repo#179joshjon wants to merge 1 commit into
joshjon wants to merge 1 commit into
Conversation
…repo When editing repo expectations from the settings dialog (repo already in "ready" status), clicking "Save & Complete" attempted a ready→ready status transition which was not in the valid transitions map, causing an untagged error that mapped to 500. Now UpdateRepoSetupStatus treats same-status transitions as a no-op. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where pressing 'Save & Complete' in the repo expectations settings dialog returned an internal server error if the repo was already in the
readystate. The setup status transition validation rejected theready → readytransition.Changes
UpdateRepoSetupStatuswhen the current status already matches the target status, treating it as a no-op instead of an invalid transitionTestUpdateSetup_MarkReadyWhenAlreadyReadyto verify that editing expectations on an already-ready repo succeeds