Hygiene batch 2: govulncheck in CI, real smoke pipeline, drop redundant step - #171
Merged
Conversation
…nt step - H3: 'mise run vuln' (govulncheck) + fatal CI step. The local baseline check was blocked by network flakiness; this PR's own CI run is the baseline gate — auto-merge cannot fire if it is dirty. - H6: smoke hydrates via FetchRunDetailsGraphQL (the production path; it exercised only the REST fallback before) and finishes with the analysis engine + LLM formatter, covering fetch -> store -> analyze -> render in one run. - H8: the 'Test schema migration' CI step re-ran TestMigration already covered by 'mise run test'; dropped. The migration unit tests build genuine old-schema databases. (ROADMAP H3, H6, H8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROADMAP H3 + H6 + H8.
mise run vulntask + fatal CI step after the race detector. Honest note: the local baseline run was blocked by this machine's intermittent network (vuln.go.dev unreachable), so this PR's own CI run is the baseline verification — if any dependency has a known finding, CI fails here and auto-merge never fires.cmd/smokenow hydrates viaFetchRunDetailsGraphQL— the mandated pre-PR smoke test was exercising only the REST fallback while every real CLI run used GraphQL batching — and finishes by running the analyzer engine and rendering the LLM briefing: one smoke run now covers fetch → store → analyze → render. Verified against cli/cli:Analyzed 5 runs: 9 findings ... LLM briefing renders (12861 bytes).TestMigrationthatmise run testhad already executed two steps earlier; the migration unit tests construct genuine old-schema databases (including the new dead-index drop).