fix(smart): treat target probe transport errors as failures - #14
Open
yt433 wants to merge 2 commits into
Open
Conversation
Treat transport errors returned by target-specific status checks as failures, so unhealthy nodes are excluded for that target. Assisted-by: OpenAI Codex
Verify that transport errors fail target-specific checks while successful responses remain healthy. Assisted-by: OpenAI Codex
liuran001
pushed a commit
to liuran001/mihomo
that referenced
this pull request
Aug 20, 2026
chore: report detailed errors for invalid Clash-style domain patterns
Owner
|
误判会增加，因为测试域名构建时只包含顶级域名 |
|
[Smart] Maximum file size limit reached (100 MB), stopping data collection 这个可以改一下？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatusTestas failures.Why
When a low-download HTTPS connection triggers a target-specific recheck, the existing code only updates
failurewhen the check returns no error. A timeout, EOF, or other transport error therefore leaves the node eligible for the same target.This change makes transport errors participate in the existing per-target failure cache and node filtering, without changing the global health-check URL or globally blocking the node.
Tests
go test ./adapter/outboundgroup ./component/smart/...AI assistance
Investigation, patch preparation, and test generation were performed with assistance from OpenAI Codex. The changes were reviewed and submitted by @yt433.