[cfg, megatron, doc] fix: honor actor.router_replay or fail if it disagrees with engine - #7466
Open
YeonwooSung wants to merge 1 commit into
Open
Conversation
…agrees with engine Fixes verl-project#7463 Co-authored-by: Grok <grok@x.ai> Signed-off-by: YeonwooSung <neos960518@gmail.com>
YeonwooSung
requested review from
PeterSH6,
eric-haibin-lin,
tongyx361,
vermouth1992,
wucong25 and
wuxibin89
as code owners
August 19, 2026 02:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7463.
actor.yamland the Ascend NPU guide documentactor_rollout_ref.actor.router_replay.mode. The Megatron/VeOmni worker only readsactor.{megatron,veomni}.router_replay.mode. Setting the documented key left routing replay disabled.This PR:
disabledactor-levelrouter_replayonto the engine config when the engine is stilldisabled.experimental/separationR2 vs R3 handling read the engine copy first.Closed #3762 asked whether routing replay would be supported (it is). This is the split-schema no-op, not a request to add the feature.
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI)Test
Local machine did not have the full verl test env. Ruff passed on the touched files. Please run the CPU test in CI.
API and Usage Example
Design & Code Changes
McoreActorConfig/VeOmniActorConfig.__post_init__callActorConfig.sync_router_replay_to_engine(). Enginerouter_replayfields are frozen, so the copy usesobject.__setattr__(same pattern asFSDPActorConfigsyncingstrategy).Checklist Before Submitting
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaystests/workers/config/.ci-requestchannel in theverlSlack workspace.recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.AI assistance was used to locate the bug and draft the patch. A human author reviewed every changed line.