Skip to content

fix(kernel): stabilize fused entropy for negative logits - #7439

Open
WangBD2023hdu wants to merge 1 commit into
verl-project:mainfrom
WangBD2023hdu:fix/fused-entropy-negative-logits
Open

fix(kernel): stabilize fused entropy for negative logits#7439
WangBD2023hdu wants to merge 1 commit into
verl-project:mainfrom
WangBD2023hdu:fix/fused-entropy-negative-logits

Conversation

@WangBD2023hdu

Copy link
Copy Markdown

Use negative infinity as the max-reduction identity and masked value so all-negative logits remain shift invariant. Add single-device and tensor-parallel regression coverage.

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Use negative infinity as the max-reduction identity and masked value so all-negative logits remain shift invariant. Add single-device and tensor-parallel regression coverage.

Co-authored-by: OpenAI Codex <noreply@openai.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wangbaode seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@WangBD2023hdu
WangBD2023hdu marked this pull request as draft August 16, 2026 13:29
@WangBD2023hdu
WangBD2023hdu marked this pull request as ready for review August 16, 2026 13:30
@WangBD2023hdu WangBD2023hdu reopened this Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants