Fix #1154, #1155: auto-link descriptions and import scheme-less event URLs#1385
Open
maxliesegang wants to merge 1 commit into
Open
Fix #1154, #1155: auto-link descriptions and import scheme-less event URLs#1385maxliesegang wants to merge 1 commit into
maxliesegang wants to merge 1 commit into
Conversation
… scheme-less event URLs Apply make_clickable() to the iCal DESCRIPTION before nl2br() so plain URLs and e-mail addresses pasted into event descriptions (e.g. from Nextcloud) become clickable links (verdigado#1155). Normalise the iCal URL field via sunflower_normalize_url(): prepend https:// when the scheme is missing (e.g. "www.example.com"). Previously FILTER_VALIDATE_URL rejected such URLs, so they were dropped from the "More Information" link and stored unusable in _sunflower_event_url meta. The normalised value is now reused for both the link and the meta (verdigado#1154).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply make_clickable() to the iCal DESCRIPTION before nl2br() so plain URLs and e-mail addresses pasted into event descriptions (e.g. from Nextcloud) become clickable links (#1155).
Normalise the iCal URL field via sunflower_normalize_url(): prepend https:// when the scheme is missing (e.g. "www.example.com"). Previously FILTER_VALIDATE_URL rejected such URLs, so they were dropped from the "More Information" link and stored unusable in _sunflower_event_url meta. The normalised value is now reused for both the link and the meta (#1154).