Skip to content

vbms32_micro.lisp charge-ok fix #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Seminko wants to merge 2 commits into
base: main
Choose a base branch
from
Open

vbms32_micro.lisp charge-ok fix #100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2728505
main-ctrl charge-ok vc_charge_end check
Seminko Jul 15, 2026
575387c
start-fun charge-ok vc_charge_start check
Seminko Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions vbms32_micro/vbms32_micro.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,8 @@ loopwhile-thd
(setq init-done true)

(setq charge-ok (and
; charging should only start if the voltage is lower than vc_charge_start
(< c-max (bms-get-param 'vc_charge_start))
(< c-max (bms-get-param 'vc_charge_end))
(> c-min (bms-get-param 'vc_charge_min))
(< t-max (bms-get-param 't_charge_max))
Expand Down Expand Up @@ -644,6 +646,8 @@ loopwhile-thd
(bms-get-param 'vc_charge_end)
(bms-get-param 'vc_charge_start)
))
; Since vc_charge_start can be set higher than vc_charge_end in VESC tool, we need to always check for that
(< c-max (bms-get-param 'vc_charge_end))
(> c-min (bms-get-param 'vc_charge_min))
(< t-max (bms-get-param 't_charge_max))
(> t-min (bms-get-param 't_charge_min))
Expand Down