Repository navigation
chore(deps): bump the aws group across 1 directory with 8 updates - #26895
dependabot[bot] wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
AWS-enabled builds cannot compile because aws-config 1.12.0 passes a schema 0.2.0 protocol type into aws-types 1.7.0, which expects schema 1.1.0.
🤖 Bits Code Review · Commit 34ec5ad
| "aws-smithy-async", | ||
| "aws-smithy-runtime-api", | ||
| "aws-smithy-schema", | ||
| "aws-smithy-schema 1.1.0", |
There was a problem hiding this comment.
Keep aws-types compatible with the pinned aws-config
Enabling aws-core compiles the unchanged aws-config 1.12.0, which unconditionally calls builder.set_protocol(self.protocol) with SharedClientProtocol from aws-smithy-schema 0.2.0. Upgraded aws-types 1.7.0 expects the corresponding type from schema 1.1.0. These are distinct Rust types, so AWS-enabled builds fail even without a custom protocol configured. Regenerate the lockfile with a compatible aws-config/aws-types pair, either upgrading them together or retaining the compatible aws-types version.
React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it
What each reaction means
- 👍 Useful: correct, and you're fixing it or will.
- 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
- 😕 Unclear: you can't tell what it means or why it matters.
- 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.
🤖 Bits Code Review · Open Bits AI session
da2a88b to
adec084
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: adec084993
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "aws-smithy-runtime" | ||
| version = "1.14.0" | ||
| version = "1.16.1" |
There was a problem hiding this comment.
Keep the AWS crates on one compatibility line
When any AWS-backed source, sink, or secrets provider is enabled, this upgrades the Smithy runtime to the new compatibility line while leaving aws-config at 1.12.0 and every service client on the previous line; the resulting lockfile contains both aws-smithy-schema 0.2.0 and 1.1.0. AWS's October 20 release notes explicitly state that these affected crates must be upgraded together and that a partial update with a previously published aws-config is unsupported. Upgrade aws-config and the service SDK crates as part of this change, or keep the runtime crates on their previous versions.
Useful? React with 👍 / 👎.
a4421a1 to
2e906bb
Compare
Bumps the aws group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [aws-credential-types](https://github.com/smithy-lang/smithy-rs) | `1.3.0` | `1.3.1` | | [aws-types](https://github.com/smithy-lang/smithy-rs) | `1.6.0` | `1.7.0` | | [aws-smithy-async](https://github.com/smithy-lang/smithy-rs) | `1.3.0` | `1.3.1` | | [aws-smithy-http](https://github.com/smithy-lang/smithy-rs) | `0.64.0` | `0.64.2` | | [aws-smithy-runtime](https://github.com/smithy-lang/smithy-rs) | `1.14.0` | `1.16.1` | | [aws-smithy-runtime-api](https://github.com/smithy-lang/smithy-rs) | `1.16.0` | `1.19.2` | | [aws-smithy-types](https://github.com/smithy-lang/smithy-rs) | `1.6.3` | `1.9.1` | | [aws-smithy-http-client](https://github.com/smithy-lang/smithy-rs) | `1.4.0` | `1.5.2` | Updates `aws-credential-types` from 1.3.0 to 1.3.1 - [Release notes](https://github.com/smithy-lang/smithy-rs/releases) - [Changelog](https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md) - [Commits](https://github.com/smithy-lang/smithy-rs/commits) Updates `aws-types` from 1.6.0 to 1.7.0 - [Release notes](https://github.com/smithy-lang/smithy-rs/releases) - [Changelog](https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md) - [Commits](https://github.com/smithy-lang/smithy-rs/commits) Updates `aws-smithy-async` from 1.3.0 to 1.3.1 - [Release notes](https://github.com/smithy-lang/smithy-rs/releases) - [Changelog](https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md) - [Commits](https://github.com/smithy-lang/smithy-rs/commits) Updates `aws-smithy-http` from 0.64.0 to 0.64.2 - [Release notes](https://github.com/smithy-lang/smithy-rs/releases) - [Changelog](https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md) - [Commits](https://github.com/smithy-lang/smithy-rs/commits) Updates `aws-smithy-runtime` from 1.14.0 to 1.16.1 - [Release notes](https://github.com/smithy-lang/smithy-rs/releases) - [Changelog](https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md) - [Commits](https://github.com/smithy-lang/smithy-rs/commits) Updates `aws-smithy-runtime-api` from 1.16.0 to 1.19.2 - [Release notes](https://github.com/smithy-lang/smithy-rs/releases) - [Changelog](https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md) - [Commits](https://github.com/smithy-lang/smithy-rs/commits) Updates `aws-smithy-types` from 1.6.3 to 1.9.1 - [Release notes](https://github.com/smithy-lang/smithy-rs/releases) - [Changelog](https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md) - [Commits](https://github.com/smithy-lang/smithy-rs/commits) Updates `aws-smithy-http-client` from 1.4.0 to 1.5.2 - [Release notes](https://github.com/smithy-lang/smithy-rs/releases) - [Changelog](https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md) - [Commits](https://github.com/smithy-lang/smithy-rs/commits) --- updated-dependencies: - dependency-name: aws-credential-types dependency-version: 1.3.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws - dependency-name: aws-smithy-async dependency-version: 1.3.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws - dependency-name: aws-smithy-http dependency-version: 0.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws - dependency-name: aws-smithy-http-client dependency-version: 1.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws - dependency-name: aws-smithy-runtime dependency-version: 1.16.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws - dependency-name: aws-smithy-runtime-api dependency-version: 1.19.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws - dependency-name: aws-smithy-types dependency-version: 1.9.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws - dependency-name: aws-types dependency-version: 1.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws ... Signed-off-by: dependabot[bot] <support@github.com>
2e906bb to
58e883c
Compare
Bumps the aws group with 8 updates in the / directory:
1.3.01.3.11.6.01.7.01.3.01.3.10.64.00.64.21.14.01.16.11.16.01.19.21.6.31.9.11.4.01.5.2Updates
aws-credential-typesfrom 1.3.0 to 1.3.1Commits
Updates
aws-typesfrom 1.6.0 to 1.7.0Changelog
Sourced from aws-types's changelog.
... (truncated)
Commits
Updates
aws-smithy-asyncfrom 1.3.0 to 1.3.1Commits
Updates
aws-smithy-httpfrom 0.64.0 to 0.64.2Commits
Updates
aws-smithy-runtimefrom 1.14.0 to 1.16.1Changelog
Sourced from aws-smithy-runtime's changelog.
... (truncated)
Commits
Updates
aws-smithy-runtime-apifrom 1.16.0 to 1.19.2Commits
Updates
aws-smithy-typesfrom 1.6.3 to 1.9.1Commits
Updates
aws-smithy-http-clientfrom 1.4.0 to 1.5.2Commits