Repository navigation
Conversation
Consume verified release assets, sign with an isolated OpenPGP subkey, and publish incremental apt/yum repositories through conditional S3 writes. Include protected maintenance commands, offline CI coverage, native package checks, and operator documentation. Production publication remains gated until migration cutover. AI assistance: GPT-6 (Codex).
700c6a3 to
9b15dbc
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The completed static review identified no actionable correctness defects. Automated publication remains gated off; readiness for production cutover was not established.
🤖 Bits Code Review · Commit 9b15dbc
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bfc6bf8fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Two of the most critical issues are: the ARMv7 repository URL replacement misses URLs without a trailing slash, causing HTTP 404 on repo refresh; and enabling default-https-client features in vdev/Cargo.toml introduces a second Rustls provider that conflicts with Vector's Ring provider, causing panics in workspace builds.
🤖 Bits Code Review · Commit 02eb039
There was a problem hiding this comment.
Two distinct issues were identified: a GitHub Actions concurrency group configuration that can silently drop pending release publications, and a DNF transaction failure caused by unconditionally requesting the full curl package on systems with curl-minimal installed.
🤖 Bits Code Review · Commit 04afe1b
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a63c2a645b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
More details
The static review identified no reportable defect in publication retries, rollback, or repository trust migration. Production publishing and native package-client integration were not rerun.
🤖 Bits Code Review · Commit b11727b
Preserve curl-minimal during RPM prerequisite repair and verify the published opt-in vdev archive before execution. AI assistance: GPT-6 (Codex).
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c28075e82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for path in "${candidates[@]}"; do | ||
| [[ -f "$path" && "$path" != "$source_file" ]] || continue | ||
| if [[ "$path" == "$timber_file" && "${CSM_MIGRATE:-false}" == true ]]; then continue; fi | ||
| if awk '!/^[[:space:]]*[#;]/ && /vector-[0-9]+|^\[vector\]/ { found=1 } END { exit !found }' "$path"; then |
There was a problem hiding this comment.
Detect indented duplicate RPM repository sections
When another .repo file defines an indented header such as [vector], this preflight does not detect it because the header pattern is anchored at column one, even though the migration parser later explicitly accepts leading whitespace around [vector]. The script therefore creates a second repository with the same ID instead of refusing the ambiguous configuration, leaving DNF/YUM to resolve conflicting repository settings; allow leading whitespace in this predicate.
Useful? React with 👍 / 👎.
Summary
Move Vector's apt/yum publication from Datadog release tooling to COSE S3 with a Vector-owned signing key. Merge #26848 first; this integration PR is stacked on its branch.
Changes
dd-pkginstallation linting with native package checks.Automated production publication remains disabled. The protected status canary, migration materials, announcement, and routing cutover remain outstanding. Signing trusts authorized GitHub release publishers; independent build-provenance verification is deferred.
References
Vector configuration
No Vector runtime configuration changes. Publisher settings and public signing fingerprints are pinned in
distribution/repositories/production.json.How did you test this PR?
The stacked-base
test-denycheck still reports the existing zstd advisories. The fix in #26845 has merged into master; the prerequisite PR’s dependency check is green.Is this a breaking change?
Does this PR include user facing changes?
no-changeloginstead of a separate fragment.Contributor Guidelines
Signed commits; published review history is preserved.